Pass the nodeID downstream of acp118 verifier #3606
+42
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua-kim
reviewed
Dec 17, 2024
joshua-kim
reviewed
Dec 18, 2024
network/p2p/acp118/handler_test.go
Outdated
| verifier: &testVerifier{}, | ||
| name: "signature signed", | ||
| cacher: &cache.Empty[ids.ID, []byte]{}, | ||
| verifierErrs: nil, |
There was a problem hiding this comment.
This line can be deleted entirely iirc because the zero value of a slice is safe to use
| @@ -10,7 +10,7 @@ require ( | |||
| github.com/DataDog/zstd v1.5.2 | |||
| github.com/NYTimes/gziphandler v1.1.1 | |||
| github.com/antithesishq/antithesis-sdk-go v0.3.8 | |||
| github.com/ava-labs/coreth v0.13.9-rc.2-encapsulate-signer | |||
There was a problem hiding this comment.
Is there a corresponding PR to coreth for this change? Wondering what this diff is for
There was a problem hiding this comment.
quite minimal. I can't really create a final version until this one is merged since I'd need to tag it.. but these are the expected changes : ava-labs/coreth#710
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Adding the previously verified source of a message allow us to cross-validate the application level signature.
How this works
Add the nodeID to the verifier interface and pass it along.
How this was tested
Unit test was updated to validate the correctness of the code.
Need to be documented in RELEASES.md?
No.