-
Notifications
You must be signed in to change notification settings - Fork 656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: correct spelling #9528
Conversation
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9528 +/- ##
==========================================
- Coverage 29.51% 29.50% -0.02%
==========================================
Files 1442 1446 +4
Lines 108594 108625 +31
Branches 41502 41502
==========================================
- Hits 32055 32053 -2
- Misses 73418 73453 +35
+ Partials 3121 3119 -2
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Description
Now that we have moved the dictionaries into autowarefoundation and added basic common dictionaries, let's make this check required again.
This PR fixes the spelling errors found in the following daily workflow:
❌ https://github.com/autowarefoundation/autoware.universe/actions/runs/12076804289/job/33678713106#step:3:60
This PR won't change any logic, it's a documentation and renaming-refactor based.
How was this PR tested?
Basic CI.
And will run it against the spell checker to see if there are any errors left:
✅ It has passed!
Notes for reviewers
The PR is very simple, even if there are lots of packages modified, the changes are very narrow scoped.
Interface changes
None.
Effects on system behavior
None.