Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: correct spelling #9528

Merged
merged 13 commits into from
Dec 2, 2024
Merged

refactor: correct spelling #9528

merged 13 commits into from
Dec 2, 2024

Conversation

xmfcx
Copy link
Contributor

@xmfcx xmfcx commented Nov 29, 2024

Description

Now that we have moved the dictionaries into autowarefoundation and added basic common dictionaries, let's make this check required again.

This PR fixes the spelling errors found in the following daily workflow:
https://github.com/autowarefoundation/autoware.universe/actions/runs/12076804289/job/33678713106#step:3:60

This PR won't change any logic, it's a documentation and renaming-refactor based.

How was this PR tested?

Basic CI.

And will run it against the spell checker to see if there are any errors left:
It has passed!

Notes for reviewers

The PR is very simple, even if there are lots of packages modified, the changes are very narrow scoped.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
@xmfcx xmfcx self-assigned this Nov 29, 2024
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) component:simulation Virtual environment setups and simulations. (auto-assigned) tag:require-cuda-build-and-test labels Nov 29, 2024
Copy link

github-actions bot commented Nov 29, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@xmfcx xmfcx added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 29, 2024
@xmfcx xmfcx added the tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) label Nov 29, 2024
@xmfcx xmfcx marked this pull request as ready for review November 29, 2024 18:46
Copy link

codecov bot commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 29.50%. Comparing base (0831075) to head (dfed666).
Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
..._shape_estimation/lib/tensorrt_shape_estimator.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9528      +/-   ##
==========================================
- Coverage   29.51%   29.50%   -0.02%     
==========================================
  Files        1442     1446       +4     
  Lines      108594   108625      +31     
  Branches    41502    41502              
==========================================
- Hits        32055    32053       -2     
- Misses      73418    73453      +35     
+ Partials     3121     3119       -2     
Flag Coverage Δ *Carryforward flag
differential 31.81% <75.00%> (?)
total 29.51% <ø> (-0.01%) ⬇️ Carriedforward from 0831075

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xmfcx xmfcx enabled auto-merge (squash) November 29, 2024 19:21
Copy link
Member

@HansRobo HansRobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@xmfcx xmfcx disabled auto-merge December 2, 2024 05:07
@xmfcx xmfcx merged commit 41c5956 into main Dec 2, 2024
42 of 45 checks passed
@xmfcx xmfcx deleted the refactor/spelling branch December 2, 2024 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:simulation Virtual environment setups and simulations. (auto-assigned) tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) tag:require-cuda-build-and-test tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants