feat(diagnostic_graph_utils): publish error graph instead of the terminal log #9421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component:system
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
…inal log Signed-off-by: Takayuki Murooka <[email protected]>
Signed-off-by: Takayuki Murooka <[email protected]>
takayuki5168
force-pushed
the
feat/pub-diag-graph
branch
from
584594f to
2f210eb
Compare
Signed-off-by: Takayuki Murooka <[email protected]>
takayuki5168
commented
Nov 21, 2024
4 tasks
Co-authored-by: Takagi, Isamu <[email protected]>
Signed-off-by: Takayuki Murooka <[email protected]>
|
@isamu-takagi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The diag_graph_utils's output to the terminal is a bit too frequent to fill the whole terminal screen.
Instead of the output to the terminal, this PR makes the diag_graph_utils publish the string message of the error diag graph so that the Rviz can visualize it as follows.
Related links
How was this PR tested?
psim worked well
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.