-
Notifications
You must be signed in to change notification settings - Fork 656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add yolov10 node #9198
base: main
Are you sure you want to change the base?
feat: add yolov10 node #9198
Conversation
Signed-off-by: suchang <[email protected]>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Signed-off-by: suchang <[email protected]>
Signed-off-by: suchang <[email protected]>
Signed-off-by: suchang <[email protected]>
Signed-off-by: suchang <[email protected]>
Signed-off-by: suchang <[email protected]>
Signed-off-by: suchang <[email protected]>
2024-11-04.16.59.28.mp4 |
Signed-off-by: suchang <[email protected]>
@@ -0,0 +1,197 @@ | |||
// Copyright 2022 TIER IV, Inc. | |||
// | |||
// Licensed under the Apache License, Version 2.0 (the "License"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@storrrrrrrrm
[must]
Can you use Apache 2.0?
Did you check the licence of Yolov10? It is AGPL3.0
both the training code and the models produced by that code are covered by AGPL-3.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Morning Shin san @Shin-kyoto , the cf link you provide can not be open due to net block policy
I read the AGPL3.0 license,which is pretty strict when code used for commercial purpose,at the same time it may also contaminate the project。While Apache 2.0 looks more friendly。
for the inference code ,since we reference the original code from tire4‘s tensorrt-yolo-x, so i believe it should follow the tire4 license。 And for the model and retrain code,we are not sure how to deal with。
I have an idea and would like to discuss with you
- create a tensorrt-yolo-v10 node in autoware universe repo using apache 2.0。 Highlight a notice in the readme file which tell the developer that model and retrained model under AGPL 3.0, those who want to use the model in their project shall consider the license issue seriously
- and if 1 works ,we may fork the retrain code in a separate repo outside autoware and retrain the original model with tire4 dataset then release the fine-tune model for autoware developer use
What do you think about the above solution,feel free to hear comment from you
Have a nice day!
Xingang
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Shin-kyoto and @liuXinGangChina 👋
Yes, this is just the inference code. And the inference code is based on autoware_tensorrt_yolox package which uses Apache 2.0. So this package can also make use of this license.
We should separate the training, model and inference licenses.
For now, @storrrrrrrrm could you update the readme file to include the information about the training code and the model licenses?
Signed-off-by: suchang <[email protected]>
Co-authored-by: M. Fatih Cırıt <[email protected]>
Description
add yolov10 node
Related links
#8753
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.