Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(default_ad_api): add log when operation mode change fails #7590

Conversation

isamu-takagi
Copy link
Contributor

@isamu-takagi isamu-takagi commented Jun 19, 2024

Description

Modify error response message.
Add warn log to guide user to GUI tool.

Tests performed

  1. Launch planning simulation.
  2. Request to change to autonomous mode without setting pose and goal.

ros2 service call /api/operation_mode/change_to_autonomous autoware_adapi_v1_msgs/srv/ChangeOperationMode

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:system System design and integration. (auto-assigned) label Jun 19, 2024
@TakaHoribe
Copy link
Contributor

Worked as expected:
image

Copy link

stale bot commented Aug 20, 2024

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Aug 20, 2024
yukkysaito
yukkysaito previously approved these changes Dec 6, 2024
@stale stale bot removed the status:stale Inactive or outdated issues. (auto-assigned) label Dec 6, 2024
@yukkysaito
Copy link
Contributor

@isamu-takagi Will you merge this or close it?

Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@isamu-takagi
Copy link
Contributor Author

For some reason, the difference of this PR were included in #7432, so I will close it.

@isamu-takagi isamu-takagi deleted the feat/operation-mode-unavailable-log branch December 10, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:system System design and integration. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants