Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(traffic light recognition): update documents #6724

Open
wants to merge 42 commits into
base: main
Choose a base branch
from
Open

docs(traffic light recognition): update documents #6724

wants to merge 42 commits into from

Conversation

tzhong518
Copy link
Contributor

@tzhong518 tzhong518 commented Apr 2, 2024 •
edited
Loading

Description

Documentation update and topic name change.
Please also pull this PR when testing: https://github.com/tier4/autoware_launch.xx1/pull/1042

Related links

Tests performed

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) labels Apr 2, 2024
@shmpwk shmpwk requested a review from dkoldaev April 2, 2024 03:24
yukkysaito
yukkysaito reviewed Apr 3, 2024
View reviewed changes
perception/traffic_light_occlusion_predictor/README.md Outdated
Comment on lines 18 to 19
| `~/input/car/traffic_signals` | tier4_perception_msgs::msg::TrafficLightArray | vehicular traffic light signals |
| `~/input/pedestrian/traffic_signals` | tier4_perception_msgs::msg::TrafficLightArray | pedestrian traffic light signals |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are discussing to unify in the direction of Traffic Light instead of Traffic Signal, so could you please change it to light? cc @mitsudome-r

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do the names of topics need to change?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yukkysaito Friendly ping

Copy link
Contributor

@miursh miursh Apr 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tzhong518
I agree with what @yukkysaito said, that since we've changed all the traffic signal types to traffic light types, we should also change the topic name accordingly.
In this PR, or split into separate PRs, would it be possible for you to resolve the issue?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I apologize for the delay. Here are the options I believe we have. If it's not urgent, since it only affects the documentation, may I choose the first option?

  • Pause this PR until the migration is complete on June 1st.
  • Include it in the autoware_msgs branch.
  • Merge this PR now and make the necessary adjustments after the migration.

https://github.com/orgs/autowarefoundation/discussions/3862

miursh
miursh approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tzhong518
Thank you for the update!
As mentioned here, could you resolve the inconsistency between the topic name and the type?

@kminoda kminoda added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label May 17, 2024
@kminoda
Copy link
Contributor

kminoda commented Jun 14, 2024 •
edited
Loading

@tzhong518 Memo: Need to update the message name

miursh
miursh requested changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#6724 (comment)

@Shin-kyoto
Copy link
Contributor

@tzhong518
Can you resolve conflicts?

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 3, 2024 •
edited
Loading

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@github-actions github-actions bot added component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:tools Utility and debugging software. (auto-assigned) component:system System design and integration. (auto-assigned) component:map Map creation, storage, and loading. (auto-assigned) component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) component:simulation Virtual environment setups and simulations. (auto-assigned) component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) labels Dec 6, 2024
@github-actions github-actions bot removed component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:tools Utility and debugging software. (auto-assigned) component:system System design and integration. (auto-assigned) component:map Map creation, storage, and loading. (auto-assigned) component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) component:simulation Virtual environment setups and simulations. (auto-assigned) component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) labels Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktro2828 ktro2828 ktro2828 left review comments

@kminoda kminoda kminoda left review comments

@YoshiRi YoshiRi YoshiRi left review comments

@yukkysaito yukkysaito yukkysaito left review comments

@knzo25 knzo25 knzo25 left review comments

@miursh miursh miursh requested changes

@dkoldaev dkoldaev dkoldaev approved these changes

@satoshi-ota satoshi-ota Awaiting requested review from satoshi-ota satoshi-ota is a code owner

@kyoichi-sugahara kyoichi-sugahara Awaiting requested review from kyoichi-sugahara kyoichi-sugahara is a code owner

@takayuki5168 takayuki5168 Awaiting requested review from takayuki5168 takayuki5168 is a code owner

@tkimura4 tkimura4 Awaiting requested review from tkimura4 tkimura4 is a code owner

@technolojin technolojin Awaiting requested review from technolojin technolojin is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

@tzhong518 tzhong518

Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:require-cuda-build-and-test tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
Software Working Group
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@tzhong518 @kminoda @Shin-kyoto @shmpwk @knzo25 @yukkysaito @YoshiRi @miursh @dkoldaev @ktro2828