Skip to content
This repository has been archived by the owner on Oct 5, 2022. It is now read-only.

Use the new core version to sync transactions in chunks to avoid timeouts #120

Merged
merged 2 commits into from
Jun 28, 2021

Conversation

gndelia
Copy link
Contributor

@gndelia gndelia commented Jun 24, 2021

Uses the new metronome-wallet-core API to retrieve past events in chunks when performing the tx sync process.

This PR is a draft because it depends on autonomoussoftware/metronome-wallet-core#32 being merged first (once that PR is merged, I'll commit the updated version of that dependency)

This PR should fix the following ticket

@gndelia gndelia requested a review from gabmontes June 24, 2021 19:35
@gndelia gndelia self-assigned this Jun 24, 2021
@gndelia gndelia marked this pull request as ready for review June 25, 2021 21:13
Copy link
Member

@gabmontes gabmontes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the 3 new JSON files required for this PR?

@gndelia
Copy link
Contributor Author

gndelia commented Jun 25, 2021

Oops, no, I think it was part of me experimenting to make the iOS app work.. I must have accidentally committed them. I'll remove them! 😓

@gndelia gndelia force-pushed the sync-transactions-in-chunks branch from 2b93fef to 2e65cec Compare June 28, 2021 13:47
@gndelia gndelia requested a review from gabmontes June 28, 2021 13:47
@gndelia
Copy link
Contributor Author

gndelia commented Jun 28, 2021

@gabmontes Removed!

@gabmontes gabmontes merged commit 9672965 into develop Jun 28, 2021
@gabmontes gabmontes deleted the sync-transactions-in-chunks branch June 28, 2021 15:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants