-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tangodict code improvements #187
Conversation
Hi @clairecw , thank you for your PR! It looks really good in general, and I really appreciate the fact that there are unit tests. A couple of more complicated unit tests would also be helpful. Do you have other instructions for end-to-end testing that you could share as well? |
Hi @fanpu, thanks so much for the feedback! Yes, I've added unit tests testing a bit more functionality for the dictionary object specifically - if you could TAL when you get the chance and see if there's anything else you had in mind that'd be awesome! As for E2E tests, I suppose there could be tests for each of the functions in TangoServer, and maybe another file testing the endpoints themselves. |
Great job and thanks! I've looked through the changes and tests and they look good, and I've also tested it with Autolab. One last change before it's ready to be merged: could you use the unittest methods for asserting the tests instead of the native Python assert? You can refer to this file for examples. |
Tests for other Tango objects would also definitely be greatly appreciated, see #183 for some ideas Just to clarify, those tests would be better for a separate pr if you are intending to work on them, the pr right now is good apart from the assert changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent job and thanks once again for your contributions!
Implements contains in the Tango*Dictionary classes, replacing any unnecessary calls to
.keys()
.Also adds tests for TangoDictionary accordingly.
Fixes #171.