Fix student download submission bug to have unique names

[jhs-panda]

Description

Fix bug missed by #2137.
If a file has multiple files with the same name, will add unique identifier at end to differentiate files and ensure zipping for download all submissions feature for students does not run into issues.

Motivation and Context

If a student has multiple submissions with the same submission file name, downloading the submissions will run into issues because there are multiple files of the same name being zipped together. Issue occurred in production.

The change will append "_ver{#}" to the name of the file if there are multiple files with that same name to differentiate the different files and allow for smooth folder compression.

Fixes #2188.

How Has This Been Tested?

To test, duplicates the files when downloading (so file names had multiples) to ensure version naming worked.

For files that don't have duplicate file names, feature does not add the unique name modification (what it was like previously).

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• I have run rubocop and erblint for style check. If you haven't, run overcommit --install && overcommit --sign to use pre-commit hook for linting
• My change requires a change to the documentation, which is located at Autolab Docs
• I have updated the documentation accordingly, included in this PR

Other issues / help required

If unsure, feel free to submit first and we'll help you along.

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes in the UsersController focus on enhancing user management and file download functionalities. The download_all_submissions method has been modified to handle duplicate file names by introducing new hash structures to append version numbers. The create and update methods have been refined for improved error handling, providing more specific feedback for user creation and updates. Overall, these modifications strengthen error handling and user feedback mechanisms across multiple methods.

Changes

File	Change Summary
app/controllers/users_controller.rb	- Updated download_all_submissions to track duplicate file names and append version numbers.
	- Enhanced create method for specific error handling during user creation.
	- Adjusted update method for clearer error messages related to user role updates.
	- Strengthened error handling and feedback in show, edit, and destroy methods.

Assessment against linked issues

Objective	Addressed	Explanation
Fix Zip::EntryExistsError in download_all_submissions (#2188)	✅

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

app/controllers/users_controller.rb (1)

199-215: Consider adding tests for the versioning logic.

The implementation correctly handles duplicate filenames by appending version numbers while preserving file extensions. However, to prevent regression, consider adding tests that verify:

1. Files without duplicates remain unchanged
2. Duplicate files get correct version numbers
3. File extensions are preserved correctly

Would you like me to help create test cases for these scenarios?

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 96006d5 and 891efc6.

📒 Files selected for processing (1)

• app/controllers/users_controller.rb (1 hunks)

🔇 Additional comments (1)

app/controllers/users_controller.rb (1)

192-197: LGTM! Effective solution for tracking duplicate filenames.

The implementation efficiently tracks duplicate filenames using a hash with default value of 0, which is a good practice for counting occurrences.