Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint views/doorkeeper and remove more unused files #1980

Merged
merged 1 commit into from
Sep 17, 2023
Merged

Lint views/doorkeeper and remove more unused files #1980

merged 1 commit into from
Sep 17, 2023

Conversation

20wildmanj
Copy link
Contributor

@20wildmanj 20wildmanj commented Sep 12, 2023 •
edited by reviewpad bot
Loading

Summary

Summary generated by Reviewpad on 12 Sep 23 21:23 UTC

This pull request includes linting changes for the doorkeeper application views and the removal of unused files. The changes include fixing form tag attributes, updating link attributes, and removing two unused files.

Description

  • lint views/doorkeeper using erblint
  • remove unused files in lib/views

Motivation and Context

  • As part of summer linting

How Has This Been Tested?

  • ensure that doorkeeper views still work, create/edit/destroy oauth apps (Go to "Manage API Applications" in "Manage Autolab")
  • ensure that authorization pages work (Go to "Manage API Applications" and authorize an application, go to "User Profile" and click "Manage Authorized Applications")

Checklist:

  • I have run rubocop for style check. If you haven't, run overcommit --install && overcommit --sign to use pre-commit hook for linting

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Sep 12, 2023
damianhxy
damianhxy approved these changes Sep 17, 2023
View reviewed changes
Copy link
Member

@damianhxy damianhxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully created, edited, destroyed oauth applications
Successfully authorized autolab CLI
Screenshot 2023-09-17 at 11 41 24

LGTM

@20wildmanj 20wildmanj added this pull request to the merge queue Sep 17, 2023
Merged via the queue into master with commit 49417da Sep 17, 2023
6 checks passed
@20wildmanj 20wildmanj deleted the joeywildman-lint-doorkeeper branch September 17, 2023 15:55
NicholasMy pushed a commit to UB-CSE-IT/Autolab that referenced this pull request Jan 5, 2024
@20wildmanj @NicholasMy
Lint views/doorkeeper and remove more unused files (autolab#1980)
2cd6d87 
Lint doorkeeper and remove more unused files

(cherry picked from commit 49417da)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damianhxy damianhxy damianhxy approved these changes

Assignees
No one assigned
Labels
small Pull request is small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@20wildmanj @damianhxy