Lint views/admins, views/application, views/assessment_user_data, views/attachments

[20wildmanj]

Summary

Summary generated by Reviewpad on 17 Sep 23 15:43 UTC

This pull request includes the following changes:

• In the maintenance.html.erb file, the indentation of the code has been fixed.
• In the edit.html.erb file, the form has been refactored to use hash syntax instead of hash rocket syntax for options.
• In the _attachment.html.erb file, the link_to paths have been refactored to use the named route helper methods.
• In the _form.html.erb file, the indentation and spacing of the code has been adjusted for better readability.
• In the index.html.erb file, the link_to paths have been refactored to use the named route helper methods.
• In the new.html.erb file, the form has been refactored to use hash syntax instead of hash rocket syntax for options.

Please review these changes and provide any necessary feedback.

Description

• Lint views/admins, views/application, views/assessment_user_data, views/attachments using bundle exec erblint app/views/*(folder)/*(file).html.erb -a
• Replace bracket links with function (_path()) links
• Remove script in app/views/attachments/_form.html.erb seemed to previously update the file name next to the upload file button, which is now redundant with the new file_field button

Motivation and Context

• As part of Summer linting

How Has This Been Tested?

• Ensure links for attachments (both course and assessment) work, i.e. editing, deleting, downloading
• Ensure that link to course/assessment from attachment overview works (go to <course>/attachment or <course>/<assessment>attachment and click top link)
• Ensure that "Bulk Email Instructors" looks correct
• Ensure that assessment_user_data page renders (Go to gradesheet and click on link as shown below)

Checklist:

• I have run rubocop for style check. If you haven't, run overcommit --install && overcommit --sign to use pre-commit hook for linting

[lykimchee]

• Creating, editing, deleting, downloading coursewide and assessment attachments work
  NOTE @20wildmanj: Can we add a confirmation step for users before as they delete an attachment? I still approved the PR so it's okay if we don't add it, but would be nice!

• Able to get from attachment overview (both coursewide and assessment) to the course or assessment

• Bulk email instructors looks good

• Can see assessment_user_data from gradebook