Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint views/gradebook #1966

Merged
merged 3 commits into from
Sep 12, 2023
Merged

Lint views/gradebook #1966

merged 3 commits into from
Sep 12, 2023

Conversation

20wildmanj
Copy link
Contributor

@20wildmanj 20wildmanj commented Aug 21, 2023 •
edited by reviewpad bot
Loading

Summary

Summary generated by Reviewpad on 10 Sep 23 16:57 UTC

This pull request includes several changes in the code:

  • In the statistics.html.erb file, there are changes in the table structure, specifically in the <col> elements.
  • In the student.html.erb file, there are changes in the table structure as well, including the <col> elements and some spacing adjustments.
  • In the view.html.erb file, there are changes in the javascript includes and some spacing adjustments. Additionally, there is an autocomplete attribute added to an input field.

Description

  • Lint views/gradebook using bundle exec erblint app/views/gradebook/*.html.erb -a

Motivation and Context

As part of summer linting

How Has This Been Tested?

  • Ensure that Instructor gradebook renders properly
  • Ensure that Student gradebook renders properly
  • Ensure that Statistics render properly for an assessment

Checklist:

  • I have run rubocop for style check. If you haven't, run overcommit --install && overcommit --sign to use pre-commit hook for linting

@reviewpad reviewpad bot requested a review from KesterTan August 21, 2023 00:04
@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Aug 21, 2023
KesterTan
KesterTan approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@KesterTan KesterTan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@20wildmanj 20wildmanj added this pull request to the merge queue Sep 12, 2023
Merged via the queue into master with commit 304d164 Sep 12, 2023
6 checks passed
@20wildmanj 20wildmanj deleted the joeywildman-lint-views-gradebook branch September 12, 2023 21:10
NicholasMy pushed a commit to UB-CSE-IT/Autolab that referenced this pull request Jan 5, 2024
@20wildmanj @NicholasMy
Lint views/gradebook (autolab#1966)
7d92967 
* lint views/gradebook

* remove %> from comments

* fix comments

(cherry picked from commit 304d164)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KesterTan KesterTan KesterTan approved these changes

Assignees
No one assigned
Labels
small Pull request is small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@20wildmanj @KesterTan