-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 7.0 #164
Release 7.0 #164
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple suggestions, generally looking good. Thanks for taking the time to do this, I'm excited for the release.
Co-authored-by: Travis Illig <[email protected]>
Co-authored-by: Travis Illig <[email protected]>
Co-authored-by: Travis Illig <[email protected]>
Co-authored-by: Travis Illig <[email protected]>
Co-authored-by: Travis Illig <[email protected]>
Co-authored-by: Travis Illig <[email protected]>
Will go through the docs updates now the duplicate stuff is fixed. |
OK, have updated the PR to reflect the fact that Re: the |
Let me try to grab a couple of minutes and commit something to the branch. I need to read it in context and it's going to be a pain to try to figure out via a PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the registration page and moved the RegisterGeneratedFactory stuff to the Delegate Factories page because... basically it was delegate factories but with an explicit registration line that's no longer needed. Still searchable in the docs, just not on that relationships page.
I consolidated the docs about Func<X, Y, B>
so maybe it's more concise and clear what it's talking about. It did seem to jump around a lot.
Great. Looks like we're ready to go; I'll push the release tomorrow if everything looks shipshape? |
LET'S DOO ITTTTTTTT |
Oh dammit I hit the button in my excitement. Let me roll it back. |
OK, I put a PR in that just reverts this commit. Then we can, uh, revert the revert I guess. Sorry. Wasn't thinking. |
That merge button just sits there, all green and staring at you. I get it. I'll push the release tomorrow then merge the new PR. |
Docs for: