Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 7.0 #164

Merged
merged 18 commits into from
Mar 6, 2023
Merged

Release 7.0 #164

merged 18 commits into from
Mar 6, 2023

Conversation

alistairjevans
Copy link
Member

Docs for:

  • Required Properties
  • Assembly Load Context support
  • Obsolete RegisterGeneratedFactory

Copy link
Member

@tillig tillig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple suggestions, generally looking good. Thanks for taking the time to do this, I'm excited for the release.

docs/advanced/scopes-loadcontexts.rst Outdated Show resolved Hide resolved
docs/advanced/scopes-loadcontexts.rst Outdated Show resolved Hide resolved
docs/advanced/scopes-loadcontexts.rst Outdated Show resolved Hide resolved
docs/advanced/scopes-loadcontexts.rst Outdated Show resolved Hide resolved
docs/register/prop-method-injection.rst Outdated Show resolved Hide resolved
docs/register/prop-method-injection.rst Outdated Show resolved Hide resolved
docs/register/prop-method-injection.rst Outdated Show resolved Hide resolved
docs/resolve/relationships.rst Outdated Show resolved Hide resolved
docs/whats-new/upgradingfrom6to7.rst Outdated Show resolved Hide resolved
@alistairjevans
Copy link
Member Author

Will go through the docs updates now the duplicate stuff is fixed.

@alistairjevans
Copy link
Member Author

OK, have updated the PR to reflect the fact that PropertiesAutowired no longer duplicates.

Re: the Func<X, Y, B> docs, I've moved it, but to be honest I'm not certain what it's trying to say? May be I'm just not sufficiently familiar with parameterised factories; if you have any suggestions @tillig I would appreciate it.

@tillig
Copy link
Member

tillig commented Mar 6, 2023

Let me try to grab a couple of minutes and commit something to the branch. I need to read it in context and it's going to be a pain to try to figure out via a PR.

Copy link
Member

@tillig tillig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the registration page and moved the RegisterGeneratedFactory stuff to the Delegate Factories page because... basically it was delegate factories but with an explicit registration line that's no longer needed. Still searchable in the docs, just not on that relationships page.

I consolidated the docs about Func<X, Y, B> so maybe it's more concise and clear what it's talking about. It did seem to jump around a lot.

@alistairjevans
Copy link
Member Author

Great. Looks like we're ready to go; I'll push the release tomorrow if everything looks shipshape?

@tillig
Copy link
Member

tillig commented Mar 6, 2023

LET'S DOO ITTTTTTTT :shipit:

@tillig tillig merged commit dc3f00a into master Mar 6, 2023
@tillig
Copy link
Member

tillig commented Mar 6, 2023

Oh dammit I hit the button in my excitement. Let me roll it back.

@tillig tillig mentioned this pull request Mar 6, 2023
@tillig
Copy link
Member

tillig commented Mar 6, 2023

OK, I put a PR in that just reverts this commit. Then we can, uh, revert the revert I guess. Sorry. Wasn't thinking.

@alistairjevans
Copy link
Member Author

That merge button just sits there, all green and staring at you. I get it. I'll push the release tomorrow then merge the new PR.

@alistairjevans alistairjevans deleted the release-7.0 branch March 7, 2023 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants