-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add benchmarks to GHA #1405
Open
jzelinskie
wants to merge
11
commits into
authzed:main
Choose a base branch
from
jzelinskie:gha-bench
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add benchmarks to GHA #1405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzelinskie
added
area/perf
Affects performance or scalability
area/tooling
Affects the dev or user toolchain (e.g. tests, ci, build tools)
labels
Jun 23, 2023
jzelinskie
force-pushed
the
gha-bench
branch
2 times, most recently
from
June 23, 2023 17:40
02d360d
to
844f6f9
Compare
vroldanbet
previously approved these changes
Jun 27, 2023
jzelinskie
force-pushed
the
gha-bench
branch
4 times, most recently
from
July 14, 2023 19:29
84ab074
to
23621f2
Compare
This avoids tee overriding the exit code when a benchmark fails.
vroldanbet
reviewed
Mar 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jzelinskie rebased and addressed merge conflicts. PTAL
auto-merge was automatically disabled
April 4, 2024 16:42
Merge queue setting changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/docs
Affects docs or metadata (e.g. README)
area/perf
Affects performance or scalability
area/tooling
Affects the dev or user toolchain (e.g. tests, ci, build tools)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new mage target for running benchmarks and creates a new CI job for running benchmarks on a bare-metal runner without any noisy neighbors!
Thanks for the sponsor Equinix Metal!
Fixes #6