-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement uniform return interface for js functions #26
Merged
lakhansamani
merged 30 commits into
authorizerdev:develop
from
shiftlabs1:implement-uniform-return-interface-for-js-functions
Dec 4, 2023
Merged
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
8b44d71
Just trying to show how a uniformed API can help improve the use of t…
1021305
Merge branch 'main' into implement-uniform-return-interface-for-js-fu…
7af66cc
modify tests for signup
43ff120
fix with linter
407e979
modify all functions to use the unified response API
ee5bdc9
Merge branch 'main' into implement-uniform-return-interface-for-js-fu…
042a42b
bump version
3d56ab5
update clashing response name
8882921
update clashing response name
5340f1c
updated tests
9c47fc4
updated tests
e849bc6
update Response to genericResponse, to differentiate from the Http Re…
85d7d42
update Response to genericResponse, to differentiate from the Http Re…
e33b684
update test
27c5f83
update test
efcd2e9
bump
610c26e
change Response to GenericResponse in Api methods
5d423d4
change Response to GenericResponse in Api methods
251b6c4
include lib in github branch use
3dd6bc2
add method for resending verification email
7504c57
trying package version bump
489812f
lint fix copied over
1a8b492
Merge branch 'bypass' into implement-uniform-return-interface-for-js-…
ac79e5b
include lib in gitignore
ae3d10f
As per recommendations, make errors of type Error[], change response …
8d05e35
fix with linter
53dc974
remove ok property
c65fca4
remove lib folders from PR
c45a548
remove lib folder
0dadca0
Merge branch 'main' into implement-uniform-return-interface-for-js-fu…
lakhansamani File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,4 +3,7 @@ | |
node_modules | ||
dist | ||
lib | ||
package-lock.json | ||
lib/* | ||
package-lock.json | ||
.idea | ||
.history |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we add
lib
back to git ignore as that should not be part of the repo.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was my bad , i removed it while testing the lib via github
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated now