refactors and new algorithms #978
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
panva
commented
Sep 11, 2024
•
panva
commented
- chore: ignore package-lock.json
- refactor: use async node:crypto methods when available
- test: remove deprecated use of Buffer()
- feat: add support for curve secp256k1 (ES256K)
- feat: add support for Ed25519 and Ed448 (EdDSA)
panva
force-pushed
the
wip
branch
2 times, most recently
from
ae413b9 to
5331137
Compare
panva
force-pushed
the
wip
branch
2 times, most recently
from
dffd632 to
593b04d
Compare
panva
force-pushed
the
wip
branch
2 times, most recently
from
c010d65 to
6f3d63b
Compare
jakelacey2012
approved these changes
Sep 11, 2024
jakelacey2012
approved these changes
Sep 12, 2024
jakelacey2012
approved these changes
Oct 3, 2024
4 tasks
There was a problem hiding this comment.
Hi @panva & @jakelacey2012 👋
Anything blocking us from merging those improvements?
There was a problem hiding this comment.
Should we bump the version to "version" : "10.0.0" ?
There was a problem hiding this comment.
Nope, this is not breaking the declared supported engines.
Anything blocking us from merging those improvements?
Nothing from my end.
There was a problem hiding this comment.
Do we need to add a few more reviewers?
Seems that ci/circleci is still having some issues
ci/circleci: node-v18 Expected — Waiting for status to be reported
There was a problem hiding this comment.
I've linked the actual pipeline results above. In a followup to this @frederikprijck mentioned migrating to github actions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.