Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #952 fixed rename decode function unsafe_decode #953

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

aalu-love
Copy link

#952 I have made the changes as per the above mentioned in the above comment.

Description

Renamed decode function to unsafe_decode where ever it has define in the code.

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not the default branch

…ht the risk

auth0#952 I have made the changes as per above mentioned in the above comment.
@@ -243,7 +243,7 @@ jwt.verify(token, getKey, options, function(err, decoded) {
<details>
<summary><em></em>Need to peek into a JWT without verifying it? (Click to expand)</summary>

### jwt.decode(token [, options])
### jwt.unsafe_decode(token [, options])

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aalu-love Could you make it camelCase? So it can match javascript default case

@@ -0,0 +1,7268 @@
{
"name": "jsonwebtoken",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the package-lock wasn't committed before which is not the best practice.
It might be better to add it in a different commit for visibility

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants