Upgrade to rails `6.0.4.4` #249

waldofouche · 2022-02-23T03:56:57Z

Latest rails 6 releases

Tests passed:

2 deprecation warnings total

Finished in 2 minutes 7.7 seconds (files took 11.19 seconds to load)
917 examples, 0 failures

Guard boots without issues:

➜  reporting-service git:(upgrade/rails) bundle exec guard
Notice: Your terminal-notifier is older than what terminal-notifier-guard supports, consider upgrading.
Notice: Your terminal-notifier is older than what terminal-notifier-guard supports, consider upgrading.
12:05:35 - INFO - Bundle already up-to-date
12:05:35 - INFO - Guard::RSpec is running
12:05:35 - INFO - Inspecting Ruby code style of all files
invalid option: -R
For usage information, use --help
12:05:36 - ERROR - The following exception occurred while running guard-rubocop: /Users/waldofouche/.rbenv/versions/2.7.4/lib/ruby/2.7.0/json/common.rb:156:in `parse' 783: unexpected token at '' (JSON::ParserError)
12:05:37 - INFO - 0 brakeman findings
Notice: Your terminal-notifier is older than what terminal-notifier-guard supports, consider upgrading.
Notice: Your terminal-notifier is older than what terminal-notifier-guard supports, consider upgrading.
12:05:37 - ERROR - Notification failed for Notiffany::Notifier: TerminalNotifier not installed. Please do so by running `brew install terminal-notifier`
12:05:37 - INFO - Guard is now watching at '/Users/waldofouche/dev/reporting-service'

Part of https://github.com/ausaccessfed/stockpile/issues/101

Latest rails 6 releases

Avoid using OpenStruct; use Struct, Hash, a class or test doubles instead.

gumboot/strap.rb:28:in `ensure_database': Only supports mysql2 adapter

Implementing the fix causes errors, instead, suppressing the check

ArthurZheng · 2022-02-23T04:36:23Z

config/initializers/app_config.rb

@@ -2,7 +2,7 @@

 require 'mail'
 require 'aws-sdk-sqs'
-
+# rubocop:disable Style/OpenStructUse


I got rid of OpenStruct in rapid-idp-manager.
Please commit here: https://github.com/ausaccessfed/rapid-idp-manager/pull/1135/commits/68ac2fc6536e5d2a43e948b00232c63e5dd08d6d for details. It's quite a pain to fix it and update all the tests. Just an idea for you. Not sure if it is worth the effort here.

https://github.com/ausaccessfed/rapid-idp-manager/pull/1135/commits/68ac2fc6536e5d2a43e948b00232c63e5dd08d6d

Thanks! I am unsure if it is worth the effort here, since this service is planned to die according to: https://github.com/ausaccessfed/stockpile/issues/101

Should I go down this rabbit hole @rianniello ? Happy to if required

IMO not worthwhile

(not worth the effort, though good to get this off old rails in meantime 👍)

matthew-puku · 2022-02-28T23:00:13Z

Might be easier just go to Rails 6.0.x, reporting service should be well and truly dead by the time that hits EOL

waldofouche · 2022-03-01T01:27:42Z

Might be easier just go to Rails 6.0.x, reporting service should be well and truly dead by the time that hits EOL

I agree, will fix up this PR to only go to 6.0.4.4

As suggested in: #249 (comment)

Manually checked the changes and applied relevant ones

Used to fix: DEPRECATION WARNING: Static attributes will be removed in FactoryBot 5.0. Please use dynamic attributes instead by wrapping the attribute value in a block:

waldofouche · 2022-03-01T08:14:14Z

Been digging at that for a while, maybe the caching has changed? Would you mind taking a look for me when you have a moment @matthew-puku ? Bit lost

matthew-puku · 2022-03-01T23:22:28Z

@waldofouche Tests pass now. Rubocop is very unhappy, though. I would probably just remove it now that you've gotten what you wanted from it.

waldofouche · 2022-03-02T01:02:34Z

Thanks for your help @matthew-puku , I agree, I'll remove rubocop now

No longer required

config/environments/production.rb

bin/setup

matthew-puku

Looks alright to me. reporting-service isn't super important so I'm pretty happy to just send this to test and see what it does. Less need to comb over the diff as rigorously as usual 🤷

waldofouche · 2022-03-02T02:17:24Z

Agree @matthew-puku , if the build fails we can just revert and the errors will help us troubleshoot

waldofouche · 2022-03-02T06:17:30Z

Having no issues using reporting service in test currently, I think everything is all good here @matthew-puku

https://reporting.test.aaf.edu.au/dashboard

rianniello · 2022-03-07T04:26:29Z

👍

* aaf-develop: Add platform `x86_64-linux` (ausaccessfed#252) Upgrade to rails `6.0.4.4` (ausaccessfed#249) Resolved-Conflicts: * config/environments/production.rb - adjacent changes: config.log_level changed to :info locally in 5e1e309

* code-develop: Version: 1.4.5-tuakiri2 Add platform `x86_64-linux` (ausaccessfed#252) Upgrade to rails `6.0.4.4` (ausaccessfed#249)

vladimir-mencl-eresearch · 2022-03-08T01:55:21Z

Hi,

I've just rolled it out into production - thanks for the work.

Note that this also upgraded the execjs gem from 2.7.0 to 2.8.1 "again". This version of execjs drops support for therubyracer - this caused problems earlier, reported in #240 - and back then, it was solved by reverting execjs back to 2.7.0.

I have now solved it by just installing nodejs and that works, so not an issue anymore.

But as therubyracer is no longer used, it might be worth removing it from the dependencies - it's still explicitly listed in Gemfile: https://github.com/ausaccessfed/reporting-service/blob/develop/Gemfile#L11

Cheers,
Vlad

see #249 (comment)

* aaf-develop: Bump nokogiri from 1.13.4 to 1.13.6 (ausaccessfed#259) Bump rack from 2.2.3 to 2.2.3.1 (ausaccessfed#260) fix: mysqld_safe: command not found (ausaccessfed#258) Bump nokogiri from 1.13.3 to 1.13.4 (ausaccessfed#256) Bump puma from 5.6.2 to 5.6.4 (ausaccessfed#255) Gemfile updates (ausaccessfed#254) Add platform `x86_64-linux` (ausaccessfed#252) Upgrade to rails `6.0.4.4` (ausaccessfed#249) Bump nokogiri from 1.12.5 to 1.13.3 Bump puma from 5.5.2 to 5.6.2 Update puma to 5.5.2

waldofouche added 3 commits February 23, 2022 11:55

Upgrade to rails 6.1.4.4

0df99e9

Latest rails 6 releases

Address rubocop violations (Automatic)

5831707

Address rubocop violation Style/OpenStructUse

f5629ab

Avoid using OpenStruct; use Struct, Hash, a class or test doubles instead.

This comment was marked as resolved.

Sign in to view

waldofouche added 2 commits February 23, 2022 12:19

Remove broken ensure_activerecord_databases check

721093c

gumboot/strap.rb:28:in `ensure_database': Only supports mysql2 adapter

Suppress Style/OpenStructUse violation

eb552e4

Implementing the fix causes errors, instead, suppressing the check

This comment was marked as outdated.

Sign in to view

waldofouche marked this pull request as ready for review February 23, 2022 04:32

waldofouche requested a review from a team February 23, 2022 04:32

ArthurZheng reviewed Feb 23, 2022

View reviewed changes

This comment was marked as outdated.

Sign in to view

waldofouche marked this pull request as draft February 28, 2022 06:25

Merge branch 'develop' into upgrade/rails

a91a0a2

Revert to rails 6.0.4.4

04da39d

As suggested in: #249 (comment)

waldofouche changed the title ~~Upgrade to rails 6.1.4.4~~ Upgrade to rails 6.0.4.4 Mar 1, 2022

waldofouche added 4 commits March 1, 2022 10:24

Update using Rails app:update

16d7e37

Manually checked the changes and applied relevant ones

Fix bin/setup

48be674

Enable zietwerk auto loader

f20add7

Fix test configuration

dba95e0

This comment was marked as resolved.

Sign in to view

waldofouche added 3 commits March 1, 2022 15:54

Add rubocop-rspec

4ee6c8b

Used to fix: DEPRECATION WARNING: Static attributes will be removed in FactoryBot 5.0. Please use dynamic attributes instead by wrapping the attribute value in a block:

Address RSpec DEPRECATIONS

7e3b216

Address Rubocop Violations (Automatic)

cb5bc1b

Revert cache configuration for tests

c8ad62b

Remove rubocop-rspec gem

8d2a9aa

No longer required

waldofouche marked this pull request as ready for review March 2, 2022 01:46

waldofouche requested review from ArthurZheng, rianniello and matthew-puku March 2, 2022 01:46

matthew-puku requested changes Mar 2, 2022

View reviewed changes

config/environments/production.rb Outdated Show resolved Hide resolved

bin/setup Show resolved Hide resolved

waldofouche added 2 commits March 2, 2022 10:01

Restore torba pack

131479b

Restore some previous configurations for prod

a55c10d

matthew-puku approved these changes Mar 2, 2022

View reviewed changes

waldofouche merged commit d9cfe90 into develop Mar 2, 2022

waldofouche deleted the upgrade/rails branch March 2, 2022 02:28

vladimir-mencl-eresearch mentioned this pull request Mar 7, 2022

Update Rails 6.0 to 6.0.4.6 #253

Closed

waldofouche added a commit that referenced this pull request Mar 8, 2022

Remove therubyracer gem

7dceb28

see #249 (comment)

waldofouche mentioned this pull request Mar 8, 2022

Gemfile updates #254

Merged

waldofouche removed request for ArthurZheng and rianniello March 8, 2022 02:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade to rails `6.0.4.4` #249

Upgrade to rails `6.0.4.4` #249

waldofouche commented Feb 23, 2022 •

edited

Loading

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as outdated.

ArthurZheng Feb 23, 2022 •

edited

Loading

waldofouche Feb 24, 2022

matthew-puku Feb 24, 2022

rianniello Feb 25, 2022

rianniello Feb 25, 2022

This comment was marked as outdated.

matthew-puku commented Feb 28, 2022

waldofouche commented Mar 1, 2022

This comment was marked as resolved.

waldofouche commented Mar 1, 2022

matthew-puku commented Mar 1, 2022

waldofouche commented Mar 2, 2022

matthew-puku left a comment

waldofouche commented Mar 2, 2022

waldofouche commented Mar 2, 2022 •

edited

Loading

rianniello commented Mar 7, 2022

vladimir-mencl-eresearch commented Mar 8, 2022

Upgrade to rails 6.0.4.4 #249

Upgrade to rails 6.0.4.4 #249

Conversation

waldofouche commented Feb 23, 2022 • edited Loading

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as outdated.

ArthurZheng Feb 23, 2022 • edited Loading

Choose a reason for hiding this comment

waldofouche Feb 24, 2022

Choose a reason for hiding this comment

matthew-puku Feb 24, 2022

Choose a reason for hiding this comment

rianniello Feb 25, 2022

Choose a reason for hiding this comment

rianniello Feb 25, 2022

Choose a reason for hiding this comment

This comment was marked as outdated.

matthew-puku commented Feb 28, 2022

waldofouche commented Mar 1, 2022

This comment was marked as resolved.

waldofouche commented Mar 1, 2022

matthew-puku commented Mar 1, 2022

waldofouche commented Mar 2, 2022

matthew-puku left a comment

Choose a reason for hiding this comment

waldofouche commented Mar 2, 2022

waldofouche commented Mar 2, 2022 • edited Loading

rianniello commented Mar 7, 2022

vladimir-mencl-eresearch commented Mar 8, 2022

Upgrade to rails `6.0.4.4` #249

Upgrade to rails `6.0.4.4` #249

waldofouche commented Feb 23, 2022 •

edited

Loading

ArthurZheng Feb 23, 2022 •

edited

Loading

waldofouche commented Mar 2, 2022 •

edited

Loading