test null default connection within ConnectionLocator and throw Conne…

…ctionNotFound from getDefault() on a null default
auraphp · Nov 4, 2021 · 42146a0 · 42146a0
1 parent 04b6657
commit 42146a0
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/src/ConnectionLocator.php b/src/ConnectionLocator.php
@@ -90,9 +90,14 @@ public function setDefault(callable $callable): void
      *
      * @return ExtendedPdoInterface
      *
+     * @throws Exception\ConnectionNotFound
      */
     public function getDefault(): ExtendedPdoInterface
     {
+        if (! $this->default) {
+            throw new Exception\ConnectionNotFound("default");
+        }
+
         if (! $this->default instanceof ExtendedPdo) {
             $this->default = call_user_func($this->default);
         }

diff --git a/tests/ConnectionLocatorTest.php b/tests/ConnectionLocatorTest.php
@@ -49,6 +49,13 @@ protected function newLocator($read = [], $write = [])
         return new ConnectionLocator($this->default, $read, $write);
     }
 
+    public function testNullDefault()
+    {
+        $locator = new ConnectionLocator(null, $this->read, $this->write);
+        $this->expectException('Aura\Sql\Exception\ConnectionNotFound');
+        $locator->getDefault();
+    }
+
     public function testGetDefault()
     {
         $locator = $this->newLocator();