-
Notifications
You must be signed in to change notification settings - Fork 559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Serialization for khash map #76
Open
dnbaker
wants to merge
27
commits into
attractivechaos:master
Choose a base branch
from
dnbaker:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
6800c6f
Add writing
dnbaker cbeb0bc
Merge branch 'master' of https://github.com/noseatbelts/klib
dnbaker 061969d
Add write/load functions.
dnbaker 3277f05
Update khash.h
dnbaker 494da2e
Update write/read functions to work for both sets and maps.
dnbaker a6755a4
Merge branch 'master' of https://github.com/attractivechaos/klib
dnbaker 9f5e92e
Add kputuw_, kputw_, and kputl_ functions (which don't set 0).
dnbaker 4375b21
Eliminate -Wsign-compare.
dnbaker 121adbd
Modify kputuw_.
dnbaker 309d5e5
Add HAS_KPUTUW__ macro for checking for function definition.
dnbaker 1de0874
Merge branch 'master' of https://github.com/attractivechaos/klib
dnbaker 69dc025
Finished moving things around.
dnbaker 8598156
Merge branch 'master' of https://github.com/dnbh/klib
dnbaker 0089a12
Merge branch 'master' of https://github.com/attractivechaos/klib
dnbaker 751f62a
save
dnbaker 3597c24
Merge branch 'master' of https://github.com/noseatbelts/klib
dnbaker 384eea5
Merge branch 'master' of https://github.com/attractivechaos/klib
dnbaker 2327449
Merge branch 'master' of https://github.com/attractivechaos/klib
dnbaker 3e30f52
Allow switch to 64-bit map using -DKH_USE_64_BIT
dnbaker f6247bb
Eliminate second definition of kh_write.
dnbaker 718511e
Save changes.
dnbaker 3122f7e
Save stuff.
dnbaker 8fbee11
Resolve.
dnbaker 6694ef8
Patch.
dnbaker 16d6366
Remove unrelated changes.
dnbaker f0f7639
Update documentation. Add serialize method.
dnbaker 653e8d8
Merge branch 'master' of https://github.com/attractivechaos/klib
dnbaker File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This duplicates a lot of code and it's not clear how it's related to the serialization.
kputl
could callkputl_
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is unrelated to serialization. I added this so that I'd have the option of integer formatting routines which did not null-terminate for cases where I knew I would be appending to the string further. I can separate that out from this pull request later if requested. Compare kputw and kputw_ which were already present, for example. I'm not quite sure I understand why only some types were provided separate functions.