Fix compiler error on OS X 10.6

.clang-format

@@ -0,0 +1,19 @@
+# Use the Google style with these modifications and a couple of others:
+#
+# 1) Lines can be up to 100 chars long rather than 80.
+# 2) Use a four space indent rather than two spaces.
+#
+Language: Cpp
+BasedOnStyle: Google
+ColumnLimit: 100
+IndentWidth: 4
+
+# The following directives override defaults established above.
+
+# We don't want OCLint pragmas to be reformatted.
+CommentPragmas: '^!OCLINT'
+
+# Do not try to infer the most common alignment of `&` and `*` by analyzing the
+# source file. Use right alignment; i.e., bind to the symbol not the type.
+DerivePointerAlignment: false
+PointerAlignment: Right

.clang-tidy

@@ -0,0 +1,3 @@
+CheckOptions:
+  - key: readability-braces-around-statements.ShortStatementLines
+    value: 1

.copr/Makefile

@@ -0,0 +1,7 @@
+mkfile_path := $(abspath $(lastword $(MAKEFILE_LIST)))
+current_dir := $(notdir $(patsubst %/,%,$(dir $(mkfile_path))))
+
+srpm:
+	dnf -y install git-core sed
+	$(current_dir)/prep.sh
+	rpmbuild -bs -D "dist %{nil}" -D "_sourcedir packaging/fedora" -D "_srcrpmdir $(outdir)" --nodeps packaging/fedora/ksh.spec

.copr/prep.sh

@@ -0,0 +1,35 @@
+#!/bin/sh -euf
+set -x
+
+# Copr sets clone depth to 500 to avoid cloning big repositories
+# however we use number of commits in version number, so fetch
+# full repository
+# If `get fetch --unshallow` fails, this means if we have full
+# repo, so ignore if it fails.
+git fetch --unshallow || :
+
+# Fetch tags to determine version number
+git fetch --tags
+
+# 2017.0.0-devel-1535-g7c33a1cd-dirty
+VCS_VERSION=$(git describe --always --dirty --tags)
+
+# Extract development version number i.e. 2017.0.0
+DEVEL_VERSION_NUM=$(echo "$VCS_VERSION" | cut -d'-' -f1)
+
+# 1535
+COMMIT_NUM=$(echo "$VCS_VERSION" | cut -d'-' -f3)
+
+# g7c33a1cd
+SHORT_COMMIT=$(echo "$VCS_VERSION" | cut -d'-' -f4)
+
+COMMIT=$(git rev-parse HEAD)
+
+sed "s,#VCS_VERSION#,${VCS_VERSION},;
+     s,#DEVEL_VERSION_NUM#,${DEVEL_VERSION_NUM},;
+     s,#COMMIT_NUM#,${COMMIT_NUM},;
+     s,#SHORT_COMMIT#,${SHORT_COMMIT},;
+     s,#COMMIT#,${COMMIT}," \
+         packaging/fedora/ksh.spec.in > packaging/fedora/ksh.spec
+
+git archive --prefix "ast-${COMMIT}/" --format "tar.gz" HEAD -o "packaging/fedora/ksh-${SHORT_COMMIT}.tar.gz"

.cppcheck.rules

@@ -0,0 +1,26 @@
+<?xml version="1.0"?>
+
+<![CDATA[
+<!-- Sadly we can't enable the following two rules since doing so causes false
+     positives in standard header files rather than just project specific
+     source files. If we can find a way to enable these rules by also
+     excluding system include files we should do so.
+<rule version="1">
+    <pattern> wcwidth \(</pattern>
+    <message>
+        <id>wcwidthForbidden</id>
+        <severity>warning</severity>
+        <summary>Always use fish_wcwidth rather than wcwidth.</summary>
+    </message>
+</rule>
+
+<rule version="1">
+    <pattern> wcswidth \(</pattern>
+    <message>
+        <id>wcswidthForbidden</id>
+        <severity>warning</severity>
+        <summary>Always use fish_wcswidth rather than wcswidth.</summary>
+    </message>
+</rule>
+<--!>
+]]>

.cppcheck.suppressions

@@ -0,0 +1,26 @@
+// suppress all instances of varFuncNullUB: "Passing NULL after the last typed
+// argument to a variadic function leads to undefined behaviour." That's
+// because all the places we do this are valid and won't cause problems even
+// on a ILP64 platform because we're careful about using NULL rather than 0.
+varFuncNullUB
+// Suppress the warning about unmatched suppressions. At the moment these
+// warnings are emitted even when removing the suppression comment results in
+// the warning being suppressed. In other words this unmatchedSuppression
+// warnings are false positives.
+unmatchedSuppression
+// There is currently one function which triggers this warning multiple times:
+// src/cmd/ksh93/sh/io.c. Those warnings are all false positives. Suppressing
+// them with inline warnings is too hideous to allow so globally suppress them.
+resourceLeak
+// For the moment we ignore warnings about using non-reentrant functions when
+// a reentrant thread-safe variant exists. Since ksh is single-threaded this
+// isn't a problem although it could be is a third-party plugin created
+// threads that used any of these functions.
+getpwuidCalled
+ttynameCalled
+getloginCalled
+getpwnamCalled
+// The fallbacks.c module is likely to need cppcheck suppressions. But due to
+// how they are parsed, independent of any enclosing `#if` directives, they are
+// also likely to cause warnings like "Unmatched suppression: mktempCalled".
+unmatchedSuppression:../src/lib/libast/misc/fallbacks.c

.editorconfig

@@ -0,0 +1,13 @@
+root = true
+
+[*]
+indent_size = 4
+indent_style = space
+end_of_line = lf
+charset = utf-8
+trim_trailing_whitespace = true
+insert_final_newline = true
+max_line_length = 100
+
+[{Makefile,*.in}]
+indent_style = tab

.github/ISSUE_TEMPLATE/bug_report.md

@@ -0,0 +1,26 @@
+---
+name: Bug report
+about: Template for bug reports
+---
+
+**Description of problem:**
+
+
+**Ksh version:**
+
+
+**How reproducible:**
+
+
+**Steps to reproduce:**
+1.
+2.
+3.
+
+**Actual results:**
+
+
+**Expected results:**
+
+
+**Additional info:**

.gitignore

@@ -0,0 +1,38 @@
+# There are some patterns below we include reluctantly. They should be in an
+# individual's ~/.config/git/ignore file. For example, ".DS_Store" for people
+# working on MacOS. We include them to help ensure they arent't added to the
+# project.
+
+# Files and file extensions that should never be checked in regardless of
+# which project directory they reside in.
+*.exe
+*.app
+*.so
+*.dylib
+*.dll
+*.lai
+*.la
+*.a
+*.lib
+*.o
+*.obj
+*.lo
+*.slo
+*.d
+*.gch
+*.pch
+*.bak
+*.new
+*.orig
+*.log
+*.DS_Store
+*~
+*~HEAD
+.AppleDouble
+.LSOverride
+.Trash-*
+._*
+Desktop.ini
+
+# Artifacts of the build, install, and test process that should not be committed.
+build/

.oclint

@@ -0,0 +1,130 @@
+rules:
+rule-configurations:
+    # This is the default value (as of the time I wrote this) but I'm making
+    # it explicit since it needs to agree with the value used by clang-format.
+    # Thus, if we ever change the style guide to allow longer or shorter lines
+    # this should be changed (as well as the corresponding .clang-format file).
+    - key: LONG_LINE
+      value: 100
+
+    # The default limit for the length of variable names is 20. Long names are
+    # problematic but twenty chars results in way too many errors. So increase
+    # the limit to something more reasonable.
+    - key: LONG_VARIABLE_NAME
+      value: 30
+
+    # TODO: Return this to a saner value such as 60 (or even 100) once the
+    # truly obscene functions have been refactored.
+    #
+    # We're slightly more persmissive regarding the total number of lines in a
+    # function. Default is 50.
+    - key: LONG_METHOD
+      value: 500
+
+    # TODO: Return this to the default of 5 once the more egregious nested
+    # blocks have been eliminated.
+    #
+    # We're slightly more persmissive regarding the nested block depth.
+    # Default is 5.
+    - key: NESTED_BLOCK_DEPTH
+      value: 7
+
+    # We're slightly more persmissive regarding the number of non-comment
+    # lines in a function. Default is 30.
+    - key: NCSS_METHOD
+      value: 40
+
+    # We're willing to allow slighly more linearly independent paths through a
+    # function. Most of our code has a lot of `switch` blocks or consecutive
+    # `if` tests that are straightforward to interpret but which increase this
+    # metric. Default is 10.
+    - key: CYCLOMATIC_COMPLEXITY
+      value: 14
+
+    # We're willing to allow slighly more execution paths through a function.
+    # Default is 200.
+    - key: NPATH_COMPLEXITY
+      value: 300
+
+disable-rules:
+    #
+    # A few instances of "useless parentheses" errors are meaningful. Mostly
+    # in the context of the `return` statement. Unfortunately the vast
+    # majority would result in removing parentheses that decreases
+    # readability. So we're going to ignore this warning and rely on humans to
+    # notice when the parentheses are truly not needed.
+    #
+    # Also, some macro expansions, such as FD_SET(), trigger this warning and
+    # we don't want to suppress each of those individually.
+    #
+    - UselessParentheses
+    #
+    # OCLint wants variable names to be at least three characters in length.
+    # Which would be fine if it supported a reasonable set of exceptions
+    # (e.g., "i", "j", "k") and allowed adding additional exceptions to match
+    # conventions employed by a project. Since it doesn't, and thus generates
+    # a lot of really annoying warnings, we're going to disable this rule.
+    #
+    - ShortVariableName
+    #
+    # This rule flags perfectly reasonable conditions like `if (!some_condition)`
+    # and is therefore just noise. Disable this rule.
+    #
+    - InvertedLogic
+    #
+    # The idea behind the "double negative" rule is sound since constructs
+    # like "!!(var & flag)" should be written as "static_cast<bool>(var &
+    # flag)". Unfortunately this rule has way too many false positives;
+    # especially in the context of assert statements. So disable this rule.
+    #
+    - DoubleNegative
+    #
+    # Avoiding bitwise operators in a conditional is a good idea with one
+    # exception: testing whether a bit flag is set. Which happens to be the
+    # only time you'll see something like `if (j->flags & JOB_CONSTRUCTED)`
+    # in project source.
+    #
+    - BitwiseOperatorInConditional
+    #
+    # I don't think I've ever seen a case where assigning a value to a
+    # parameter inside the function body was unclear, let along dangerour or
+    # an error. This rule is therefore just noise. Disable this rule.
+    #
+    - ParameterReassignment
+    #
+    # The project makes so much use of the `goto` statement, many of which
+    # will require significant refactoring to remove, that warnings about its
+    # use are just noise.
+    #
+    - GotoStatement
+    #
+    # Oclint has too many false positives regarding missing `break;`
+    # statements. Mostly having to do with `case` blocks that use  `goto` to
+    # exit the block. In some cases because it doesn't recognize
+    # `__builtin_unreachable()` to flag that the previous statement won't
+    # return. And the compiler already alerts us to case blocks that fall
+    # through to the next case block.
+    - MissingBreakInSwitchStatement
+    #
+    # This warning is perfectly reasonable for most projects but not for ksh.
+    # There are simply too many `switch` blocks with as little as two branches
+    # but which we cannot justify rewriting.
+    # TODO: Enable this warning in the future.
+    #
+    - TooFewBranchesInSwitchStatement
+    #
+    # The structure of the code means that it is often clearer to nest `if()`
+    # statements even though they could be written as a single `if()`. I've
+    # simplified all the instances where no clarity is lost by combining them.
+    # Those instances that remain would be made harder to read and reason
+    # about if they were combined. Eliminating these instances requires
+    # refactoring that is hard to justify. So disable this warning.
+    - CollapsibleIfStatements
+    #
+    # TODO: Enable These in the future after simpler or more serious issues
+    # have been addressed. At this time these warnings just make it hard to
+    # see the issues that are easier or more urgent to resolve. So disable them.
+    #
+    - HighCyclomaticComplexity
+    - HighNPathComplexity
+    - HighNcssMethod