This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
package: adopt prettier-standard style #310
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The main repo uses Prettier, it would be best to be consistent with that. This is the Prettier config. |
|
Thanks! I'll convert this pr to use prettier when i get the chance |
This'll help to catch any errors in new code and keep its style consistent While we're at it also uninstall unused `coffeelint` and remove files belonging to it
Also moves `temp` to `devDependencies`, as it's only used by specs The reorder isn't necessary, but I feel it is cleaner
Almost all of these changes were made automatically
List of errors that had to be resolved manually:
(`no-template-curly-in-string` errors were resolved by turning the rule off)
.../snippets/lib/snippets.js
156:31 error Expected error to be handled handle-callback-err
164:9 error Unexpected literal in error position of callback standard/no-callback-literal
171:31 error Expected error to be handled handle-callback-err
286:7 error Expected error to be handled handle-callback-err
358:11 error Expected error to be handled handle-callback-err
372:14 error Unexpected literal in error position of callback standard/no-callback-literal
.../snippets/spec/body-parser-spec.js
26:7 error Unexpected template string expression no-template-curly-in-string
54:39 error Unexpected template string expression no-template-curly-in-string
65:39 error Unexpected template string expression no-template-curly-in-string
79:7 error Unexpected template string expression no-template-curly-in-string
111:39 error Unexpected template string expression no-template-curly-in-string
129:39 error Unexpected template string expression no-template-curly-in-string
151:39 error Unexpected template string expression no-template-curly-in-string
171:39 error Unexpected template string expression no-template-curly-in-string
189:39 error Unexpected template string expression no-template-curly-in-string
.../snippets/spec/snippets-spec.js
75:41 error Unexpected template string expression no-template-curly-in-string
199:19 error Unexpected template string expression no-template-curly-in-string
257:19 error Unexpected template string expression no-template-curly-in-string
271:19 error Unexpected template string expression no-template-curly-in-string
276:19 error Unexpected template string expression no-template-curly-in-string
280:19 error Unexpected template string expression no-template-curly-in-string
285:15 error Unexpected template string expression no-template-curly-in-string
289:19 error Unexpected template string expression no-template-curly-in-string
293:19 error Unexpected template string expression no-template-curly-in-string
297:19 error Unexpected template string expression no-template-curly-in-string
301:19 error Unexpected template string expression no-template-curly-in-string
1335:23 error Unexpected template string expression no-template-curly-in-string
1355:19 error Unexpected template string expression no-template-curly-in-string
1360:19 error Unexpected template string expression no-template-curly-in-string
1385:14 error Unexpected template string expression no-template-curly-in-string
1397:14 error Unexpected template string expression no-template-curly-in-string
fluvf
changed the title
|
I've now added prettier formatting |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Installs and converts the package to
prettier-standardstyle.This is consistent with atom core, which also seems to use a custom
prettierstandardcomboWhile we're at it, also update dependencies and do some other maintenance around
package.json, see commit messages for details.The failing test also fails on master
Alternate Designs
We could copy the formatting and linting configs from atom core, but they seem unfinished and the overall setup more complex
Benefits
This will help catch any errors in, and keep the style consistent of, any new code.
Possible Drawbacks
N/A
Applicable Issues
N/A