This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Decouple core indentation logic from spec #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This pull request changes a test in spec suite which at the time of writing expects a very specfic indentation logic behavior from core: it assumes that when text is selected, hitting Tab always results in indenting the line. The aim of the pull request is somewhat to loosen the test to allow any core behavior (within reason) to occur, while retaining the constraints that make sense for this package.
Alternate Designs
None considered for now.
Benefits
The test is not as tightly coupled to the core, allowing core to change behavior without the need to update this spec.
Possible Drawbacks
There could be future developments which may pass with the new test, but that did not pass with the old one, however this should be unlikely due to the amount of similar tests which possibly catch such cases.
Applicable Issues
atom/atom#20137