Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Dynamic Notification Navigation #125

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

munezeromicha
Copy link
Contributor

What does this PR do?

This PR implements a comprehensive notification redirection system that:

  • Adds intelligent routing based on notification types (tickets, attendance, performance, etc.)
  • Handles special cases for new ticket assignments
  • Maintains notification read status when navigating
  • Provides fallback routes for unknown notification types
  • Shows appropriate error messages if navigation fails

How should this be manually tested?

  1. Login to the application

  2. Navigate to the notifications screen

  3. Test each notification type by clicking on them:

    • Click on a ticket notification -> Should redirect to /dashboard/trainee/tickets
    • Click on an attendance notification -> Should redirect to /dashboard/trainee/Attendance
    • Click on a performance/rating notification -> Should redirect to /dashboard/performance
    • Click on any other notification type -> Should redirect to /dashboard
  4. Verify that:

    • Unread notifications are marked as read after clicking
    • Error messages appear if navigation fails
    • New ticket assignment notifications correctly redirect to the tickets page

@ncutixavier ncutixavier merged commit b054176 into dev Nov 25, 2024
4 checks passed
@ncutixavier ncutixavier deleted the fix-redirect-notifications branch November 25, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants