Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Preference Page Icons #120

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Fix Preference Page Icons #120

wants to merge 1 commit into from

Conversation

niyibi250
Copy link
Contributor

@niyibi250 niyibi250 commented Nov 19, 2024 •
edited
Loading

What does this PR do?

This PR updates the trainee preference settings page to maintain consistency by replacing all buttons or clickables with Chevron icons.

Description of Task to be completed?

  • Replace the forward arrow icons on the settings page with Chevron icons for better UI consistency.
  • Ensure that the new Chevron icons are interactive and reflect the current colorScheme (light or dark mode).
  • Update the push notification section to include expand/collapse functionality, toggling between a downward and forward Chevron icon.

How should this be manually tested?

  1. Navigate to the trainee preference settings page.

  2. Verify that all forward arrows have been replaced by Chevron icons.

  3. Test the push notification section:

  • Click the Chevron icon to expand the section and reveal the switch.
  • Click the Chevron icon again to collapse the section.
  1. Ensure the Chevron icons adjust their color dynamically based on the active colorScheme.

Any background context you want to provide?

N/A

What are the relevant pivotal tracker/Trello stories?

N/A

Screenshots

image

@niyibi250 niyibi250 self-assigned this Nov 19, 2024
@niyibi250 niyibi250 added the WIP Work in progress label Nov 19, 2024
@niyibi250 niyibi250 force-pushed the fx-Preference-Page branch 2 times, most recently from 2ea5b83 to 002ada1 Compare November 19, 2024 16:07
@niyibi250 niyibi250 added ready for review and removed WIP Work in progress labels Nov 19, 2024
MugemaneBertin2001
MugemaneBertin2001 requested changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@MugemaneBertin2001 MugemaneBertin2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-11-20 100951

  1. Use standard react native icons framework instead of images in assets
  2. Check settings we have on web as that are written
  3. Change to toggle on privacy and login history just as that are on web

MugemaneBertin2001
MugemaneBertin2001 requested changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@MugemaneBertin2001 MugemaneBertin2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-11-20 132505
@niyibi250 check on these toggler on web

@niyibi250 niyibi250 force-pushed the fx-Preference-Page branch 2 times, most recently from 6edff72 to e60625e Compare November 20, 2024 15:07
pacifiquemboni
pacifiquemboni reviewed Nov 20, 2024
View reviewed changes
assets/Preference_icons/down_arrow.png
Copy link
Contributor

@pacifiquemboni pacifiquemboni Nov 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work @niyibi250
but i think iti is not advisable to use static files especially icons

pacifiquemboni
pacifiquemboni reviewed Nov 20, 2024
View reviewed changes
Copy link
Contributor

@pacifiquemboni pacifiquemboni left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work @niyibi250
but i think iti is not advisable to use static files especially icons

pacifiquemboni
pacifiquemboni reviewed Nov 20, 2024
View reviewed changes
Copy link
Contributor

@pacifiquemboni pacifiquemboni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolve conflicting files

@niyibi250 niyibi250 force-pushed the fx-Preference-Page branch 2 times, most recently from f88dcca to 1d20c3d Compare November 21, 2024 06:24
@niyibi250 niyibi250 force-pushed the fx-Preference-Page branch 4 times, most recently from 33a4a3a to 5b771da Compare November 21, 2024 15:12
@niyibi250
fix(preference): add icon and able to expand
536bee7 
- add icons on preference settings
- redirect the login activities preference

[issueid: #104]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncutixavier ncutixavier Awaiting requested review from ncutixavier

@Mbabazi12 Mbabazi12 Awaiting requested review from Mbabazi12

@munezeromicha munezeromicha Awaiting requested review from munezeromicha

@Christian-Ishimwe Christian-Ishimwe Awaiting requested review from Christian-Ishimwe

@MugemaneBertin2001 MugemaneBertin2001 Awaiting requested review from MugemaneBertin2001

@pacifiquemboni pacifiquemboni Awaiting requested review from pacifiquemboni

Assignees

@niyibi250 niyibi250

Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@niyibi250 @pacifiquemboni @MugemaneBertin2001