Skip to content

Commit

Permalink
Fix GitHub Actions warnings
Browse files Browse the repository at this point in the history
  • Loading branch information
dagguh committed Jun 6, 2024
1 parent 52b5dd7 commit 0c893ab
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 13 deletions.
25 changes: 14 additions & 11 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,26 +19,29 @@ jobs:
matrix:
jira-version: ["8.20.0", "9.4.0", "9.8.0", "9.11.0"]
env:
JIRA_SOFTWARE_VERSION: ${{ matrix.jira-version }}
JIRA_VERSION: ${{ matrix.jira-version }}
steps:
- name: Checkout
uses: actions/checkout@v2
uses: actions/checkout@v4
- name: Setup Java
uses: actions/setup-java@v4
with:
fetch-depth: 0
- name: Build
uses: gradle/gradle-build-action@v2
with:
gradle-version: wrapper
arguments: build
distribution: 'temurin'
java-version: 8
server-password: "" # avoid ```Unable to decrypt local Maven settings credentials```
- name: Setup Gradle
uses: gradle/actions/setup-gradle@v3
- name: Build with Gradle
run: ./gradlew build
- name: Upload test reports
if: always()
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v4
with:
name: test-reports
path: build/reports/tests
- name: Upload diagnoses
if: always()
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v4
with:
name: ${{ matrix.jira-version }}-diagnoses
path: build/diagnoses
Expand All @@ -56,7 +59,7 @@ jobs:
if: github.event.inputs.release == 'yes'
steps:
- name: Checkout
uses: actions/checkout@v2
uses: actions/checkout@v4
with:
fetch-depth: 0
- name: Get publish token
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import java.time.ZonedDateTime
abstract class AbstractJiraCoreScenario {
private val logger: Logger = LogManager.getLogger(this::class.java)

protected val jiraVersion = System.getenv("JIRA_SOFTWARE_VERSION") ?: "8.0.0"
protected val jiraVersion = System.getenv("JIRA_VERSION") ?: "8.0.0"

fun shouldRunScenarioWithoutErrors(jira: Jira, driver: RemoteWebDriver, rng: SeededRandom) {
logger.info("Testing Jira $jiraVersion")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ class RichTextEditorIT {

@Test
fun shouldRunScenarioWithoutErrors() {
val version = System.getenv("JIRA_SOFTWARE_VERSION") ?: "8.0.0"
val version = System.getenv("JIRA_VERSION") ?: "8.0.0"
logger.info("Testing Jira $version")
val scenario = JiraEditScenario()
val metrics = mutableListOf<ActionMetric>()
Expand Down

0 comments on commit 0c893ab

Please sign in to comment.