Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confluence: Add function get_all_pages_by_space_ids_confluence_cloud #1460

Merged
merged 3 commits into from
Oct 1, 2024

Conversation

Baarsgaard
Copy link
Contributor

I recently was tasked with bulk exporting metadata about all pages in specific spaces and found out there's a perfect endpoint for that.
It just was not available in the library.

@Baarsgaard
Copy link
Contributor Author

Baarsgaard commented Sep 30, 2024

Formatting has been fixed, on another note, would you accept a PR adding a docker-fmt target to the Makefile?:

docker-fmt: docker-qa-build
        docker run --rm -v `pwd`:/atlassian-python-api $(QA_CONTAINER) tox -e black_fmt

and tox.ini (Not added to the tox.envlist)

[testenv:black_fmt]
basepython = python3
target-version = ["py37"]
skip_install = true
deps = black
commands = black {[base]linting_targets} --exclude __pycache__

@gonchik
Copy link
Member

gonchik commented Oct 1, 2024

@Baarsgaard Sure, feel free to add PR regarding improvements of infra tasks

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 3.03030% with 32 lines in your changes missing coverage. Please review.

Project coverage is 34.29%. Comparing base (9b40bb1) to head (b68190e).
Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
atlassian/confluence.py 3.03% 32 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1460      +/-   ##
==========================================
- Coverage   34.42%   34.29%   -0.14%     
==========================================
  Files          46       46              
  Lines        8627     8664      +37     
  Branches     1611     1622      +11     
==========================================
+ Hits         2970     2971       +1     
- Misses       5530     5566      +36     
  Partials      127      127              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gonchik gonchik merged commit 78fe140 into atlassian-api:master Oct 1, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants