-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Typehints for jira.py #1418
Draft
bandophahita
wants to merge
15
commits into
atlassian-api:master
Choose a base branch
from
bandophahita:typehints
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
ddf9ab5
adding type hints
bandophahita 4dc8885
avoiding errors about override signature
bandophahita e0aaf38
adding various types packages to requirements-dev.txt
bandophahita dba6e89
adding type hints
bandophahita 3310fa6
using alias for json response type
bandophahita 124a152
allowing test action to be run manually to help troubleshoot failures
bandophahita 7145319
cannot utilize the workflow_dispatch on branches until it's been merg…
bandophahita 85a9d01
black formatting is different in 3.7
bandophahita f3274b3
urllib3 is imported directly, thus should be in the reqs
bandophahita 2969f6d
cannot use new style annotations with older versions of python
bandophahita 08a4c64
future annotations aren't available in 3.6
bandophahita bf4b4b9
looks like bandit is not able to be installed in python3.6
bandophahita 3639db7
lets see if the progress bar is causing problems
bandophahita 13161bb
ignoring the list return vs the typical dictionary
bandophahita 50dd19f
avoiding black formatter inconsistencies between 23.3 and 24.x
bandophahita File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The signature for
get
inAtlassianRestAPI
doesn't match here. So we need to override.