Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Typehints for jira.py #1418

Draft
wants to merge 15 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Dockerfile.qa
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ RUN apt-get clean
WORKDIR /atlassian-python-api
COPY requirements.txt .
COPY requirements-dev.txt .
RUN python3 -m pip config --user set global.progress_bar off
RUN python3 -m pip install --no-cache-dir --upgrade setuptools
RUN python3 -m pip install --no-cache-dir --upgrade pip
RUN python3 -m pip install --no-cache-dir --upgrade wheel
Expand Down
5 changes: 2 additions & 3 deletions atlassian/bitbucket/cloud/repositories/repositoryVariables.py
Original file line number Diff line number Diff line change
@@ -1,13 +1,12 @@
# coding=utf-8

from ..base import BitbucketCloudBase


class RepositoryVariables(BitbucketCloudBase):
def __init__(self, url, *args, **kwargs):
super(RepositoryVariables, self).__init__(url, *args, **kwargs)

def __get_object(self, data):
def __get_object(self, data) -> "RepositoryVariable":
return RepositoryVariable(
self.url_joiner(self.url, data["uuid"]),
data,
Expand Down Expand Up @@ -61,7 +60,7 @@ def each(self, q=None, sort=None):

return

def get(self, uuid):
def get(self, uuid: str): # type: ignore[override]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The signature for get in AtlassianRestAPI doesn't match here. So we need to override.

"""
Returns the pipeline with the uuid in this repository.

Expand Down
2 changes: 1 addition & 1 deletion atlassian/confluence.py
Original file line number Diff line number Diff line change
Expand Up @@ -1489,7 +1489,7 @@ def set_page_label(self, page_id, label):

return response

def remove_page_label(self, page_id, label):
def remove_page_label(self, page_id: str, label: str):
"""
Delete Confluence page label
:param page_id: content_id format
Expand Down
Loading
Loading