Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove broken 'author' parameter in Bamboo create_comment #1407

Merged
merged 2 commits into from
Jun 5, 2024

Conversation

StardustGogeta
Copy link
Contributor

The Bamboo create_comment function does not work, returning an error that the author field is unrecognized and invalid. The field should be removed to fix the behavior.

We can also see that the author field is not present in the documented API, linked below:
https://developer.atlassian.com/server/bamboo/rest/api-group-api/#api-api-latest-result-projectkey-buildkey-buildnumber-comment-post

Making this change allows posting comments, as expected.

Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.37%. Comparing base (d2fd7fa) to head (37868a2).
Report is 19 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1407   +/-   ##
=======================================
  Coverage   34.37%   34.37%           
=======================================
  Files          46       46           
  Lines        8585     8585           
  Branches     1601     1601           
=======================================
  Hits         2951     2951           
  Misses       5511     5511           
  Partials      123      123           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gonchik gonchik merged commit d052dc5 into atlassian-api:master Jun 5, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants