[WIP] [JIRA] new method get_issue_status_changelog + docs + example +small improvement get_issue #1357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ments_ids_from_issue
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1357 +/- ##
==========================================
- Coverage 34.15% 34.14% -0.02%
==========================================
Files 46 46
Lines 8437 8444 +7
Branches 1188 1190 +2
==========================================
+ Hits 2882 2883 +1
- Misses 5440 5446 +6
Partials 115 115 ☔ View full report in Codecov by Sentry. |
Spacetown
suggested changes
Mar 23, 2024
atlassian/jira.py
Outdated
| @@ -1109,6 +1104,8 @@ def get_issue( | |||
| params["fields"] = fields | |||
| if properties is not None: | |||
| params["properties"] = properties | |||
| if expand: | |||
| params["expand"] = expand | |||
| if update_history is True: | |||
There was a problem hiding this comment.
Would also write:
params["updateHistory"] = str(update_history).lower()instead of:
if update_history is True:
params["updateHistory"] = "true"
if update_history is False:
params["updateHistory"] = "false"
atlassian/jira.py
Outdated
| @@ -1867,6 +1864,20 @@ def set_issue_status(self, issue_key, status_name, fields=None, update=None): | |||
| data["update"] = update | |||
| return self.post(url, data=data) | |||
|
|
|||
| def get_issue_status_changelog(self, issue_id): | |||
| # Get the issue details with changelog | |||
| issue_id = self.get_issue(issue_id, expand="changelog") | |||
There was a problem hiding this comment.
Do not override issue_id, name it response.
There was a problem hiding this comment.
@gkowalc could you commit into that PR please
There was a problem hiding this comment.
done, I implemented both suggestions.
|
thx for the revierw @Spacetown, let me refactor the code a bit accordign to your suggestions and send a new PR. |
gonchik
changed the title
|
@gkowalc thanks for update |
gonchik
pushed a commit
that referenced
this pull request
Apr 22, 2024
…example (#1377) * fixing minor issue in scrap_regex_from_issue method * new Confluence method scrap_regex_from_page+ docs + examples * added method get_attachments_ids_from_page to jira.py * added method download_attachments_from_issue * refactoring download_all_attachments_from_page method * finished download_attachments_from_issue * added two new methods: download_attachments.from_issue and get_attachments_ids_from_issue * added fix to the infinitive loop * adding reursion depth condition * fixed reursion depth condition * added update4d jira.py with new method + docs +example * added update4d jira.py with new method + docs +exampl * fix flake8 issue * hotfix get_issue_tree_recursive * added expand to get_issue method, added new method * get_issue_status_changelog method * included param expand in get_issue method decription * WIP PR changes - #1357 * improving index.rst docs #1365 * added whiteboard methods * added confluence whiteboard endpoints --------- Co-authored-by: gkowalc <> Co-authored-by: Greg <gkowalc>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds: