-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add alternate touch event models #52
Merged
stephenwf
merged 10 commits into
atlas-viewer:main
from
abrin:add_alternate_touch_event_models
Jun 13, 2024
Merged
Add alternate touch event models #52
stephenwf
merged 10 commits into
atlas-viewer:main
from
abrin:add_alternate_touch_event_models
Jun 13, 2024
Commits on Jun 5, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 5a1b7f1 - Browse repository at this point
Copy the full SHA 5a1b7f1View commit details
Commits on Jun 9, 2024
-
we’ve found that adding a touch-model interaction on-top of the canvas-panel isn’t working. Instead, it would work better if it was built into the Atlas interaction model. This helps address some of this more cleanly: 1. it addresses the fact that the browser-event-manager registers duplicate event listeners without removing them 2. it removes the `touch-action: none;` and `pointer-events: none;` which was preventing the window from listening to scroll based touches. 3. it replaces the above with making sure that `e.preventDefault()` is called when we don’t want to scroll because this does the same thing [see this](https://developer.mozilla.org/en-US/docs/Web/CSS/touch-action) `Applications using Touch events disable the browser handling of gestures by calling preventDefault(), but should also use touch-action to ensure the browser knows the intent of the application before any event listeners have been invoked` 4. With this set, we can now use `e.preventDefault()` in various places to determine when we want the event to be passed to the window. 5. I also added some custom `user-select` settings to make sure that a long touch doesn’t try to select in Safari 6. I also found that binding touch-move to the window was causing issues, so I bound it to the parent element of the canvas. New interaction modes: 1. **ignoreSingleFingerTouch** when this is enabled a single finger touch does nothing, instead of panning, it allows the window to scroll. 2. **enablePanOnWait** in this interaction model it assumes that a user will wait a brief moment between when the press and when the move when the intent is to “pan.” **Question: can I modify the popMotionController arguments in CanvasPanel — is this a matter of defining and setting them in the `useAtlas` setup in CanvasPanel?
Configuration menu - View commit details
-
Copy full SHA for 9b4d05e - Browse repository at this point
Copy the full SHA 9b4d05eView commit details
Commits on Jun 10, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a4cda83 - Browse repository at this point
Copy the full SHA a4cda83View commit details -
Configuration menu - View commit details
-
Copy full SHA for ad9bcd0 - Browse repository at this point
Copy the full SHA ad9bcd0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7a263cb - Browse repository at this point
Copy the full SHA 7a263cbView commit details -
Configuration menu - View commit details
-
Copy full SHA for fa2d152 - Browse repository at this point
Copy the full SHA fa2d152View commit details -
Configuration menu - View commit details
-
Copy full SHA for 30e90ea - Browse repository at this point
Copy the full SHA 30e90eaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 72dafb3 - Browse repository at this point
Copy the full SHA 72dafb3View commit details
Commits on Jun 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9d508d9 - Browse repository at this point
Copy the full SHA 9d508d9View commit details
Commits on Jun 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a6aad8a - Browse repository at this point
Copy the full SHA a6aad8aView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.