-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to API 8.0 #314
Upgrade to API 8.0 #314
Conversation
Hey @seorgiy Looks really nice, much better than parsing their docs. I'll take a deeper look this weekend. Also we need to make linter pass (not sure why it fails) |
Hey, @atipugin, gentle reminder 🙄 |
Hey @seorgiy Sorry for the delay, could you update this PR also up to 7.11? |
Done |
Yeah, thanks! But we still need to figure out what to do with specs. We use I'm also not sure that What do you think, @seorgiy? |
@atipugin hey! I have improved the typebuilder, now it is fully automatic, except for the methods added to the classes. Introduced min/max constraints. Unfortunately, I am very bad at writing tests. But now it turns out that we are testing the generated classes against the generated schema. Looks not really useful to me. Still i made simple fresh file at least for basic attributes compare. Also tweaked structure a little, removed old parser, tasks moved to rakelib, take a look. (too tired to fight linter right now 😪 ) |
@atipugin ok, not it's more or less readable. PR is looks kinda messy right now which im sorry for but it's working fine |
@seorgiy GJ, man! Thanks for updating up to 8.0. Minor request - please set version to 2.1, because otherwise we have to make corresponding releases (2.1, 2.2, 2.3) based on your changelog. Let's just stick with 2.1 here |
@atipugin done |
Thanks! Merged! |
Also i tried to parse json schema from https://ark0f.github.io/tg-bot-api/openapi.json and build some parser (new rake tasks). It's not ideal in the many ways but it's something