Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Bot API 7.0 #300

Merged
merged 3 commits into from
Jan 24, 2024
Merged

Implement Bot API 7.0 #300

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6b286cd
feat: implement Bot API 7.0
atipugin Jan 10, 2024
2b43990
feat: add constraints/defaults for `max_quantity`
atipugin Jan 11, 2024
36efcb4
test: fix spec by removing `max_quantity` constraints (for now)
atipugin Jan 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/telegram/bot/types/keyboard_button_request_users.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ class KeyboardButtonRequestUsers < Base
attribute :request_id, Types::Integer
attribute? :user_is_bot, Types::Bool
attribute? :user_is_premium, Types::Bool
attribute? :max_quantity, Types::Integer.constrained(gteq: 1, lteq: 10).default(1)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why a such "fix"? I'd leave the logic and change the specs.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm too lazy to fix the specs for now. You're free to push changes if you want.

attribute? :max_quantity, Types::Integer.default(1)
end
end
end
Expand Down