Check attributes types #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
About attribute type and required value (if there is such).
Avoid `default` value for now as a work-around.
It's still questionable for me, but so says the Telegram API docs. It seems like there should be `true` value or no value at all. I'm not sure if they accept `false` value. But they don't response, as I checked.
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
|
Please, reopen. 😞 |
|
@atipugin there is Bot API v7 update. These changes would help us a lot. |
|
@AlexWayfer sorry for the delay. Could you check why CI fails? |
It wasn't easy, but I've done this shortly. I'm ready to update the whole lib to API v7 after this PR. |
atipugin
approved these changes
Dec 31, 2023
|
@AlexWayfer Thanks, merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And required values, and there are some fixes…
It resolves #283, which is already "stale", but I have no response from you. So, I've decided to fight this issue globally.