Fix numeric literal formatting #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, in some situations, formatting changes the datatype of numeric literals (xsd:double and xsd:decimal). The change happens if the lexical form is ambiguous because it does not include a fractional part. This commit checks for this condition and uses the quoted form in these cases.
|
@atextor I don't understand why the build failed. Anything I can do? |
|
Hi, I currently don't have a computer with me, but I can have a look on the
weekend. Did your build succeed locally?
Florian Kleedorfer ***@***.***> schrieb am Mi., 30. Okt.
2024, 12:52:
… @atextor <https://github.com/atextor> I don't understand why the build
failed. Anything I can do?
—
Reply to this email directly, view it on GitHub
<#40 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJEXPDS3LS3MO4BZG6JC4LZ6DCAXAVCNFSM6AAAAABQ3C4USOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBWHAZDSMRQGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
It did. |
|
@fkleedorfer It turned out there was no actual reason the build failed other than some GitHub infrastructure hickup ("Error: The operation was cancelled"). I restarted the build and it went through without problems. |
|
As always with a bugfix, a timely release will be highly appreciated! Btw the spotles-maven-plugin has been released with a new RDF formatter based on turtle-formatter, just FYI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, in some situations, formatting changes the datatype of numeric literals (xsd:double and xsd:decimal). The change happens if the lexical form is ambiguous because it does not include a fractional part.
This commit checks for this condition and uses the quoted form in these cases.
Fixes #39