feat: setup dark mode for the website #3118
Conversation
vishvamsinh28
requested review from
derberg,
akshatnema,
magicmatatjahu,
anshgoyalevil,
Mayaleeeee and
asyncapi-bot-eve
as code owners
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-3118--asyncapi-website.netlify.app/ |
vishvamsinh28
force-pushed
the
darkModeSetup
branch
from
01e01e1 to
480d737
Compare
|
@vishvamsinh28 I prefer adding the button and basic setup first. In production we need to merge whole at once as we did in the case of typescript migration |
|
As you have commented out the button so how will I check the UI of the website??? |
|
@sambhavgupta0705 I did that 4months ago in my PR but @anshgoyalevil @derberg suggested to open incremental PRs Here's the comment :- #2650 (review) |
|
After merging this PR, we will have the basic setup for dark mode in the codebase. After that, anyone can work on dark mode locally, open PRs for adding dark mode to different pages, and once we have covered every page, we can uncomment the dark mode button, making it accessible to all users. |
|
@anshgoyalevil can you please take a look here |
|
@sambhavgupta0705 @anshgoyalevil Let's do this after GSoC. By that time, if no one else has opened a PR for this issue, I will start working on it and complete it. |
|
@vishvamsinh28 can you please link the github issue of this PR |
This PR sets up dark mode for the website. The toggle button for it is currently commented out. We can uncomment it after the Tailwind CSS classes for dark mode are added to every page of the website. We will add Tailwind CSS classes to the website incrementally with different PRs for different pages.
@akshatnema @anshgoyalevil @sambhavgupta0705