feat: created toggle and checkbox components and added stories for them #3082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devilkiller-ag
requested review from
derberg,
akshatnema,
magicmatatjahu,
anshgoyalevil,
Mayaleeeee and
asyncapi-bot-eve
as code owners
✅ Deploy Preview for asyncapi-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-3082--asyncapi-website.netlify.app/ |
akshatnema
added
the
gsoc
akshatnema
requested changes
Jul 29, 2024
package.json
Outdated
| @@ -53,6 +53,7 @@ | |||
| "@next/mdx": "^14.1.0", | |||
| "@octokit/graphql": "^7.0.2", | |||
| "@slack/web-api": "^7.0.2", | |||
| "@storybook/preview-api": "^8.1.11", | |||
components/tools/Checkbox.tsx
Outdated
| @@ -0,0 +1,66 @@ | |||
| import { twMerge } from 'tailwind-merge'; | |||
|
|
|||
| export interface CheckboxProps { | |||
There was a problem hiding this comment.
Add this interface inside types folder and export it from there.
components/tools/Toggle.tsx
Outdated
| @@ -0,0 +1,50 @@ | |||
| import { twMerge } from 'tailwind-merge'; | |||
|
|
|||
| export interface ToggleProps { | |||
There was a problem hiding this comment.
export this interface from types folder.
|
@akshatnema the lighthouse accessibility test is failing by 1 point when I merged master and resolved merge conflict. Do we need to resolve it? |
akshatnema
reviewed
Aug 29, 2024
package-lock.json
Outdated
There was a problem hiding this comment.
Why there are changes in package-lock.json?
There was a problem hiding this comment.
There was a merge conflict in the version of the storybook(3.2.2). I resolved it.
akshatnema
approved these changes
Aug 29, 2024
|
/rtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates the following components and adds stories for them: