resolve code duplicate issue #807
Conversation
KhudaDad414
requested review from
fmvilas,
boyney123,
mcturco,
magicmatatjahu and
asyncapi-bot-eve
as code owners
|
✅ Deploy Preview for asyncapi-studio-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for modest-rosalind-098b67 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Kudos, SonarCloud Quality Gate passed!
|
|
@fmvilas 👁️ 🙏 |
| ); | ||
| }; | ||
|
|
||
| const V3OperationsNavigation: React.FunctionComponent<NavigationSectionProps> = ({ |
There was a problem hiding this comment.
@KhudaDad414 we will have more and more duplicated code as we are in the transition period to V3.
We should just add an exception in SonarCloud, and clean after ending support for V2.
Not sure if there is an other clean way to do it.
| ); | ||
| }; | ||
|
|
||
| const V3OperationsNavigation: React.FunctionComponent<NavigationSectionProps> = ({ |
There was a problem hiding this comment.
Naming suggestion, I find OperationNavigationV3 more readable than V3OperationsNavigation
|
#821 resolves the issue. |
Description
SonarClould check fails for the duplicate code in the open PRs: