resolve sonar issues

asyncapi · Jun 11, 2024 · 6bf9a07 · 6bf9a07
1 parent fa640ac
commit 6bf9a07
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 5 deletions.
diff --git a/apps/design-system/src/components/DropdownChipInput.stories.tsx b/apps/design-system/src/components/DropdownChipInput.stories.tsx
@@ -24,7 +24,6 @@ export const Default: Story = {
     return (
         <DropdownChipInput 
         className='w-96'
-        id="chip-input-id-chip-text"
         chips={currentChips}
         onChange={setCurrentChips} 
         chipsOptions={OPTIONS}/>
@@ -39,7 +38,6 @@ export const Disabled: Story = {
     return (
         <DropdownChipInput 
         className='w-96'
-        id="chip-input-id-chip-text"
         chips={currentChips}
         onChange={setCurrentChips} 
         isDisabled={true}
@@ -55,7 +53,6 @@ export const WithPlaceholder: Story = {
         <DropdownChipInput 
         className='w-96'
         placeholder='Add a chip'
-        id="chip-input-id-chip-text"
         chips={currentChips}
         onChange={setCurrentChips} 
         chipsOptions={OPTIONS}/>

diff --git a/packages/ui/components/DropdownChipInput.tsx b/packages/ui/components/DropdownChipInput.tsx
@@ -15,7 +15,6 @@ import { cn } from '@asyncapi/studio-utils';
 type Checked = DropdownMenuCheckboxItemProps["checked"]
 
 interface DropdownChipInputProps {
-  id: string;
   className?: string;
   chips: string[];
   chipsOptions: string[];
@@ -70,7 +69,7 @@ export const DropdownChipInput: FunctionComponent<DropdownChipInputProps> = ({
       </DropdownMenuTrigger>
       <DropdownMenuContent>
         {chipsOptions.map((chipOption) => (
-          <DropdownMenuCheckboxItem checked={chips.includes(chipOption)} onCheckedChange={() => onChipCheckedChange(chipOption)}>
+          <DropdownMenuCheckboxItem key={chipOption} checked={chips.includes(chipOption)} onCheckedChange={() => onChipCheckedChange(chipOption)}>
             {chipOption}
           </DropdownMenuCheckboxItem>
         ))}