-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#197 Produce AsyncAPI documents at build time (AsyncAPI.Saunter.Generator.Build) #219
Draft
smoerijf
wants to merge
75
commits into
asyncapi:main
Choose a base branch
from
smoerijf:#197-more-logging
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uments, default all. Added support for env vars
…data to package
… parameter handling
…-global-dotnet-tool' into asyncapi#197-Produce-AsyncAPI-documents-at-build-time # Conflicts: # src/AsyncAPI.Saunter.Generator.Cli/Commands/TofileInternal.cs
…with local nuget source
…d project to populate the local nuget source
… fix the build pipeline
…-global-dotnet-tool' into asyncapi#197-more-logging # Conflicts: # .github/workflows/ci.yaml # .gitignore # Saunter.sln # src/AsyncAPI.Saunter.Generator.Cli/Commands/TofileInternal.cs # src/AsyncAPI.Saunter.Generator.Cli/SwashbuckleImport/CommandRunner.cs # src/AsyncAPI.Saunter.Generator.Cli/readme.md # test/AsyncAPI.Saunter.Generator.Cli.Tests/AsyncAPI.Saunter.Generator.Cli.Tests.csproj # test/AsyncAPI.Saunter.Generator.Cli.Tests/IntegrationTests.cs # test/AsyncAPI.Saunter.Generator.Cli.Tests/PackAndInstallLocalTests.cs # test/Saunter.Tests/Generation/DocumentGeneratorTests/InterfaceAttributeTests.cs
smoerijf
commented
Jul 13, 2024
env: | ||
PATH: ${{ github.env.PATH }}:/home/runner/.dotnet/tools | ||
|
||
unit-test: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed separate unittest step because it causes a lot duplicate work:
- It builds to whole solution again, while the build itself already does this
- I couldn't get it working to let the test-job depend on the build job build output and use that to run tests.
smoerijf
changed the title
#197 more logging
#197 Produce AsyncAPI documents at build time
Jul 13, 2024
smoerijf
changed the title
#197 Produce AsyncAPI documents at build time
#197 Produce AsyncAPI documents at build time (AsyncAPI.Saunter.Generator.Build)
Jul 13, 2024
…at failed to generate specs, fixed now. Added an external nuget dependancy to the example project (nlog) because that made spec generation fail, fixed now. And now also testing both .NET6 & .NET8
…i#197-more-logging # Conflicts: # Saunter.sln # examples/StreetlightsAPI/StreetlightsAPI.csproj # src/AsyncAPI.Saunter.Generator.Cli/ToFile/ServiceProviderBuilder.cs # src/AsyncAPI.Saunter.Generator.Cli/readme.md # test/AsyncAPI.Saunter.Generator.Cli.Tests/AsyncAPI.Saunter.Generator.Cli.Tests.csproj # test/AsyncAPI.Saunter.Generator.Cli.Tests/IntegrationTests.cs
…-global-dotnet-tool' into asyncapi#197-more-logging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready for review, but depends on PR #217
Nuget package to generate AsyncAPI specs at build time, by injecting .targets file via the nuget package. In the injected post-build target the startup assembly is used to extract the AsyncAPI spec and those files are written to files.
Closes:
#197