Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: merged two run instruction in dockerfile. #1295

Closed
wants to merge 1 commit into from

Conversation

barnamensch056
Copy link

Description
Merged two RUN instructions in the Dockerfile into one using && to reduce the number of layers. This optimizes the Docker image by improving build times, reducing image size, and simplifying management. Fewer layers result in more efficient storage, distribution, and easier troubleshooting of changes.
Related issue(s)
https://sonarcloud.io/project/issues?open=AZFCmY8SYFR-KciwR6Ur&id=asyncapi_generator.

Copy link

changeset-bot bot commented Oct 10, 2024

🦋 Changeset detected

Latest commit: 5f79496

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@asyncapi/generator Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

Copy link

sonarcloud bot commented Oct 10, 2024

@barnamensch056 barnamensch056 changed the title refactor: Merge this RUN instruction with the consecutive ones in dockerfile. refactor: merged two run instruction in dockerfile. Oct 10, 2024
Copy link
Collaborator

@Gmin2 Gmin2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the changeset, it is not needed here, and also format the code properly, other then that
LGTM !

@derberg
Copy link
Member

derberg commented Oct 15, 2024

closing this one in favor of #1298 where we don't have much errors and contributor have already some PRs merged and reacts promptly

@derberg derberg closed this Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants