Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improved readability by removing the unnecesary escape character in generator.js #1292

Closed
wants to merge 2 commits into from

Conversation

rishabhr4
Copy link
Contributor

removed the unnecessary escape characters

the link of the issue1
issue2

removed the unnecessary escape characters
Copy link

changeset-bot bot commented Oct 8, 2024

⚠️ No Changeset found

Latest commit: 5573e4e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@derberg
Copy link
Member

derberg commented Oct 9, 2024

This one ain't gonna be that easy, you will have to do some more tests locally. Luckily, because we will deprecate nunjucks soon, you just need to do manual tests.

manual testing is described in https://github.com/asyncapi/generator/blob/master/Development.md

your change affects this feature: https://www.asyncapi.com/docs/tools/generator/file-templates

so you need to manually (just on local, without pushing to PR) test nunjucks project by extending it with some file template, and running generation, and sharing logs in this PR that show all works well. You need to add this feature in https://github.com/asyncapi/generator/tree/master/apps/generator/test/test-templates/nunjucks-template/template

some example you can copy -> https://github.com/asyncapi/template-for-generator-templates/tree/nunjucks/template/schemas

good luck!

@rishabhr4
Copy link
Contributor Author

sorry i was out of town on vacation so couldn't work on this
i will start working on this from today

Copy link

sonarcloud bot commented Oct 18, 2024

@derberg
Copy link
Member

derberg commented Nov 6, 2024

@rishabhr4 I'll be closing this one as there is no point for having a PR handing like this with no action. Feel free to open a followup once ready, especially with manual tests done

@derberg derberg closed this Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants