Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: read context file sync way when calling context model #778

Merged
merged 6 commits into from
Sep 4, 2023

Conversation

derberg
Copy link
Member

@derberg derberg commented Aug 31, 2023

Fixes #751

  • now oclif.manifest.json is also generated on local. Git ignored, but it will be published to npm as it is explicitly mentioned in package.json files
  • we read context file using node sync method as the parent function cannot run inside async function

@derberg
Copy link
Member Author

derberg commented Aug 31, 2023

@Souvikns @magicmatatjahu easy merge

@sonarcloud
Copy link

sonarcloud bot commented Sep 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@derberg
Copy link
Member Author

derberg commented Sep 4, 2023

/rtm

@asyncapi-bot asyncapi-bot merged commit 62facb0 into asyncapi:master Sep 4, 2023
11 checks passed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.54.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing context operations like add, use, list, etc.
3 participants