Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add flag to set context when it is created #752

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

AnishKacham
Copy link
Contributor

Description

  • Adds a new flag --set-current / -s to the context add command that sets the context on addition
  • Tested locally by building the cli

image

Related issue(s)
Resolves #726
See also #751

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@AnishKacham AnishKacham changed the title feat: Add flag to set context when it is created feat: add flag to set context when it is created Aug 9, 2023
@AnishKacham
Copy link
Contributor Author

Hi, @Souvikns would you review this PR first or should we get #751 resolved first?
The binary file from building the cli repository seems to work fine for this feature's purpose.

@Souvikns
Copy link
Member

Hi, @Souvikns would you review this PR first or should we get #751 resolved first? The binary file from building the cli repository seems to work fine for this feature's purpose.

well, I don't think that the issue will be affected in any way by this PR, as it just adds a flag maybe we can merge it.

@sonarcloud
Copy link

sonarcloud bot commented Aug 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@Souvikns Souvikns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, docs are auto-generated but double-check if you have to update anything. When you are ready to merge just comment with \rtm

@AnishKacham
Copy link
Contributor Author

\rtm

@Souvikns
Copy link
Member

so sorry mistype, it will be /rtm

@Souvikns
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit dcb9170 into asyncapi:master Aug 17, 2023
11 checks passed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.53.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a new flag to set context when it is created
3 participants