Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add check for package-lock.json version #185

Closed
wants to merge 1 commit into from
Closed

ci: add check for package-lock.json version #185

wants to merge 1 commit into from

Conversation

smoya
Copy link
Member

@smoya smoya commented Oct 10, 2022

Description

This PR adds an extra check in case package.json is found that will check the package-lock.json version is set to 2. Otherwise, the action will fail.

This avoids issues like asyncapi/parser-js#650.

Related issue(s)
asyncapi/parser-js#650

@derberg
Copy link
Member

derberg commented Oct 10, 2022

@smoya hey, we cannot solve it this way. Please have a look -> #177

It should be a separate workflow IMHO (not enforce it all suddenly on all projects that still use v1) + we should drop a comment to the PR instead of asking folks to go to logs and figure that issue might be related to a bad package-lock version. Something we do now with PR title (and we do it as many people were asking for help instead of going to logs)

@github-actions
Copy link

github-actions bot commented Feb 8, 2023

This pull request has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation.

There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Feb 8, 2023
@derberg
Copy link
Member

derberg commented Mar 27, 2023

@smoya you want to continue working on this one?

@github-actions github-actions bot removed the stale label Mar 28, 2023
@derberg
Copy link
Member

derberg commented Apr 19, 2023

I'll close it for now as we need different solution for it, so completely new PR
Will update #177

@derberg derberg closed this Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants