Refactor reference file loading #233
Open
+88
−196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elf-written wrappers around download_data.
…eobj and get_pkg_data_filename and translate URLError errors into warnings.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #233 +/- ##
==========================================
+ Coverage 83.36% 84.15% +0.79%
==========================================
Files 13 13
Lines 1136 1136
==========================================
+ Hits 947 956 +9
+ Misses 189 180 -9 ☔ View full report in Codecov by Sentry. |
|
Do you have any opinions about this, @cshanahan1, @tepickering, and @kecnry? If nobody opposes this approach, I'll improve the code coverage and see if I can make the code a bit more readable. |
|
thanks for catching this! i filed the original issue, but had long since forgotten about it 😅. i like what you've done so far. will give it a closer look when you're more ready to merge. a few test failures to address as well as the coverage. |
…ion_data. - Marked several of the function arguments used by the previous approach as deprecated (pending) using deprecated_renamed_argument. - Improved tests to bring calibration_data coverage to 87%.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses Issue #169 (also discussed in PR #165) by using the
astropy.config.ConfigNamespace.set_tempcontext manager to temporarily set the default data download URL and then using eitherastropy.utils.data.get_pkg_data_fileobjorastropy.utils.data.get_pkg_data_filenameto get a readable file or a path to the downloaded and cached file.However, I'm not convinced this approach leads to more elegant code than the original one. We eliminate the two wrapper functions, but the file-handling code is somewhat messy because of all the nesting. Please take a look and let me know what you think.