MNT: Infrastructure and other updates

[pllim]

I stared into the code and I couldn't unsee things, so here it is.

• Fix Review the testing coverage #37 (you already have coverage so just adding a badge)
• Fix synphot should be an OPTIONAL dependency #133 (while we're at this, you don't really need photutils or matplotlib at runtime either)
• Fix TST: Weekly tests are broken #186
• Fix Specreduce layout inconsistent with Photutils and Specutils #189
• Fix Turn unhandled warnings in CI into errors #191 (was mostly there)
• Fix Modernize packaging infrastructure #198 (you want modernization, you are getting modernization)
• Apply For downstream maintainers: astropy-dev + numpy-dev now also needs pyerfa-dev astropy#15638
• Other fixes, especially tests that were not set up properly.
• Also looks like you have remote data tests but never used --remote-data flag in any of your CI job.
• And you also download a remote file blindly for tests not marked as remote data. I turned that file into a proper package test data that is local so you would stop spamming Box.

Unable to handle this one until I get access:

• RTD webhook is broken #203

After merge, can add new job names to branch protection.

[codecov]

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (aa4ceab) 78.83% compared to head (bbf377d) 81.32%.

Files	Patch %	Lines
specreduce/fluxcal.py	50.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #202      +/-   ##
==========================================
+ Coverage   78.83%   81.32%   +2.49%     
==========================================
  Files          10       10              
  Lines         992      996       +4     
==========================================
+ Hits          782      810      +28     
+ Misses        210      186      -24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[tepickering]

we have discussed and agreed that we should require >=3.10 so that we can use the improved type annotation capabilities. this change is still staged in #182, but it would make more sense to wrap that into this PR.

[pllim]

Even numpy has not dropped Python 3.9 yet. Are you sure you want to do it so soon?

https://github.com/numpy/numpy/blob/c9340c210666afefb6946fa6f3a105856ff0e418/pyproject.toml#L19

[tepickering]

well, numpy has a much, much larger installed base to support and we don't. 3.10 isn't all that new so it's not a huge ask. if one cares at all about performance, they really want 3.11+, anyway.

[tepickering]

this is so awesome! so many cleanups and fixes i've wanted to see, but never got around to. the migration to pyproject.toml is also extremely welcome. my only niggle is that we made the decision on slack 7 months ago to set python_requires to >=3.10. this was implemented in #182, but not yet merged into main. i'm fine with merging this as-is and rebasing/revising #182 accordingly. otoh, this is probably the more sensible PR to make that change given the rest of the changes its making to package config/infrastructure.

[pllim]

Sorry about the conflict with #182 . I don't watch this repo so I was not aware of it. I replied in #202 (comment) (I think it is a little too soon but I am also not a specreduce maintainer).

Whether you want to merge this first, or cherry-pick your changes to this PR and take this over, I will leave to you.

[tepickering]

no worries on the conflicts. i would say let's merge this ASAP and i'll do what i need to do to clean up #182. it's the code changes that i've made in #182 that require 3.10+, iirc. if we want to stick with bumping the requirement there vs here, i'm fine with that. interested in @kecnry's take.

[kecnry]

I don't have any strong opinions on the order of operations - good to merge on my end! Thanks for all the improvements @pllim !

[pllim]

Then, feel free to merge! I am tempted to merge myself but I shouldn't. Thanks!