Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix adding test nodes to DAGs built using LoadMethod.DBT_MANIFEST and LoadMethod.CUSTOM #615

Merged
merged 15 commits into from
Oct 30, 2023
Merged

Fix adding test nodes to DAGs built using LoadMethod.DBT_MANIFEST and LoadMethod.CUSTOM #615

Changes from 9 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
31c1d4a
resolving issues with the DBT_MANIFEST load method when has_test attr…
Oct 19, 2023
b09fb28
🎨 [pre-commit.ci] Auto format from pre-commit.com hooks
pre-commit-ci[bot] Oct 19, 2023
ce5b99f
accidentally removed a part of the docstring. Undoing
Oct 19, 2023
81bca50
specifying argument type for the node_dependencies argument
Oct 19, 2023
998fafd
🎨 [pre-commit.ci] Auto format from pre-commit.com hooks
pre-commit-ci[bot] Oct 19, 2023
cd3c257
Merge remote-tracking branch 'origin/main' into manifest_render_metho…
Oct 23, 2023
6526ca4
tags are assigned to a test based on the parent model
Oct 23, 2023
78615d8
adding newline which I for some reason removed in an earlier commit
Oct 23, 2023
a241f1b
Merge branch 'main' into manifest_render_method_test_fix
navedgaras Oct 24, 2023
adaab2c
adding a test that checks if models that are selected by tags have te…
Oct 26, 2023
01e870f
🎨 [pre-commit.ci] Auto format from pre-commit.com hooks
pre-commit-ci[bot] Oct 26, 2023
3bfc8f9
Merge branch 'main' into manifest_render_method_test_fix
navedgaras Oct 26, 2023
3a8bf12
missed the fact that a naming change was made to the DbtProject class
Oct 26, 2023
bb58d82
adding an assert statement to ensure that a list we're looping throug…
Oct 30, 2023
61fdeaf
Merge branch 'main' into manifest_render_method_test_fix
navedgaras Oct 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions cosmos/dbt/selector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,9 @@ def should_include_node(node_id: str, node: DbtNode) -> bool:

visited_nodes.add(node_id)

if node.resource_type == DbtResourceType.TEST:
node.tags = getattr(nodes.get(node.depends_on[0]), "tags", [])

if config.tags:
if not (set(config.tags) <= set(node.tags)):
return False
Expand Down
Loading