-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix possible typo in config.py #532
Conversation
👷 Deploy Preview for amazing-pothos-a3bca0 processing.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution, @meyobagero !
What do you think if we added a test to make sure we don't regress to having the incorrect path in the future?
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #532 +/- ##
=======================================
Coverage 91.80% 91.80%
=======================================
Files 49 49
Lines 1915 1915
=======================================
Hits 1758 1758
Misses 157 157
☔ View full report in Codecov by Sentry. |
Bug fixes * Fix using ``ExecutionMode.KUBERNETES`` by @pgoslatara and @tatiana in #554 * Add support to ``apache-airflow-providers-cncf-kubernetes < 7.4.0`` by @tatiana in #553 * Improve error message in ``config.py`` by @meyobagero in #532 * Use ``returncode`` instead of ``stderr`` to determine dbt graph loading errors by @cliff-lau-cloverhealth in #547 * Fix only create task group and test task only if model has test by @raffifu in #543 * Fix ``on_warning_callback`` behaviour on ``DbtTestLocalOperator`` by @edgga, @marco9663 and @tatiana in #558 * Fix ``DbtTestOperator`` when test does not have ``test_metadata`` by @tatiana in #558 * Fix ``target-path`` not specified issue in ``dbt-project.yml`` by @tatiana in #533 Others * Docs: add reference links to dbt and Airflow columns by @TJaniF in #542 * pre-commit updates #552 and #546
Use the correct argument to the error message in the function defined at line 73 of the config.py file.
Bug fixes * Fix using `ExecutionMode.KUBERNETES` by @pgoslatara and @tatiana in #554 * Add support to `apache-airflow-providers-cncf-kubernetes < 7.4.0` by @tatiana in #553 * Improve error message in `config.py` by @meyobagero in #532 * Use `returncode` instead of `stderr` to determine dbt graph loading errors by @cliff-lau-cloverhealth in #547 * Fix `on_warning_callback` behaviour on `DbtTestLocalOperator` by @edgga, @marco9663 and @tatiana in #558 * Fix `DbtTestOperator` when test does not have `test_metadata` by @tatiana in #558 * Fix `target-path` not specified issue in `dbt-project.yml` by @tatiana in #533 Others * Docs: add reference links to dbt and Airflow columns by @TJaniF in #542 * pre-commit updates #552 and #546
Bug fixes * Fix using `ExecutionMode.KUBERNETES` by @pgoslatara and @tatiana in #554 * Add support to `apache-airflow-providers-cncf-kubernetes < 7.4.0` by @tatiana in #553 * Fix `on_warning_callback` behaviour on `DbtTestLocalOperator` by @edgga, @marco9663 and @tatiana in #558 * Use `returncode` instead of `stderr` to determine dbt graph loading errors by @cliff-lau-cloverhealth in #547 * Improve error message in `config.py` by @meyobagero in #532 * Fix `DbtTestOperator` when test does not have `test_metadata` by @tatiana in #558 * Fix `target-path` not specified issue in `dbt-project.yml` by @tatiana in #533 Others * Docs: add reference links to dbt and Airflow columns by @TJaniF in #542 * pre-commit updates #552 and #546
Bug fixes * Fix using `ExecutionMode.KUBERNETES` by @pgoslatara and @tatiana in #554 * Add support to `apache-airflow-providers-cncf-kubernetes < 7.4.0` by @tatiana in #553 * Fix `on_warning_callback` behaviour on `DbtTestLocalOperator` by @edgga, @marco9663 and @tatiana in #558 * Use `returncode` instead of `stderr` to determine dbt graph loading errors by @cliff-lau-cloverhealth in #547 * Improve error message in `config.py` by @meyobagero in #532 * Fix `DbtTestOperator` when test does not have `test_metadata` by @tatiana in #558 * Fix `target-path` not specified issue in `dbt-project.yml` by @tatiana in #533 Others * Docs: add reference links to dbt and Airflow columns by @TJaniF in #542 * pre-commit updates #552 and #546 (cherry picked from commit 427f713)
Bug fixes * Fix using `ExecutionMode.KUBERNETES` by @pgoslatara and @tatiana in #554 * Add support to `apache-airflow-providers-cncf-kubernetes < 7.4.0` by @tatiana in #553 * Fix `on_warning_callback` behaviour on `DbtTestLocalOperator` by @edgga, @marco9663 and @tatiana in #558 * Use `returncode` instead of `stderr` to determine dbt graph loading errors by @cliff-lau-cloverhealth in #547 * Improve error message in `config.py` by @meyobagero in #532 * Fix `DbtTestOperator` when test does not have `test_metadata` by @tatiana in #558 * Fix `target-path` not specified issue in `dbt-project.yml` by @tatiana in #533 Others * Docs: add reference links to dbt and Airflow columns by @TJaniF in #542 * pre-commit updates #552 and #546 (cherry picked from commit 427f713) (cherry picked from commit 61e4460)
This PR is a subset of the actual Release 1.1.2 (#560), since - for this release - we had to revert a [commit](#560 (comment)) which we don't intend to revert on the project's main branch. Bug fixes * Fix using `ExecutionMode.KUBERNETES` by @pgoslatara and @tatiana in #554 * Add support to `apache-airflow-providers-cncf-kubernetes < 7.4.0` by @tatiana in #553 * Fix `on_warning_callback` behaviour on `DbtTestLocalOperator` by @edgga, @marco9663 and @tatiana in #558 * Use `returncode` instead of `stderr` to determine dbt graph loading errors by @cliff-lau-cloverhealth in #547 * Improve error message in `config.py` by @meyobagero in #532 * Fix `DbtTestOperator` when test does not have `test_metadata` by @tatiana in #558 * Fix `target-path` not specified issue in `dbt-project.yml` by @tatiana in #533 Others * Docs: add reference links to dbt and Airflow columns by @TJaniF in #542 * pre-commit updates #552 and #546
Description
Just appropriate argument to the error message in the function defined at line 73 of the config.py file
Related Issue(s)
Breaking Change?
Not a breaking change
Checklist