Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new Logrus logger #1757

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use new Logrus logger #1757

wants to merge 1 commit into from

Conversation

jeremybeard
Copy link
Contributor

Description

This changes the CLI's use of the Logrus logging library to use a new logger instance instead of reusing the existing global logger instance of the library. This prevents debug logs being suppressed when third-party libraries that the CLI imports change the logging level of the global logger, as is at least the case for the use of the Docker Compose package mid-way through astro dev start.

Note that there are other cases where logs are being suppressed because the root "PersistentPreRunE" function that sets up the logging is overridden by some sub-commands. That issue will be fixed in another PR.

🧪 Functional Testing

  • Debug logs are continuing to print

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant